Date: Mon, 1 Apr 2002 11:17:08 -0800 From: "Crist J. Clark" <cjc@FreeBSD.ORG> To: freebsd-current@FreeBSD.ORG Cc: Emiel Kollof <coolvibe@hackerheaven.org> Subject: Re: kldxref problem Message-ID: <20020401111708.V99214@blossom.cjclark.org> In-Reply-To: <20020401003521.A88395@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Mon, Apr 01, 2002 at 12:35:21AM -0800 References: <20020330205329.D51062-100000@resnet.uoregon.edu> <3CA6BFE4.8296DF74@mindspring.com> <1017571105.901.4.camel@loki.ipv6.hackerheaven.org> <20020401003521.A88395@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 01, 2002 at 12:35:21AM -0800, David O'Brien wrote:
> On Sun, Mar 31, 2002 at 12:38:24PM +0200, Emiel Kollof wrote:
> > On Sun, 2002-03-31 at 09:51, Terry Lambert wrote:
> >
> > >
> > > Perhaps if the kernel printf also "ignored" the request to print
> > > the little S.O.B. out, there would be less confusion...
> >
> > I'm still sticking to the idea that one could test for kldxref, and if
> > it isn't there, don't execute it.
> >
> > [ -x /usr/sbin/kldxref ] && /usr/sbin/kldxref
> >
> > like so, which is perfectly sane bourne shell syntax, which is also used
> > by BSD make.
>
> Not really. Use:
>
> <target>: <deps>
> <tab>rule1
> <tab>rule2
> .if exists(/usr/sbin/kldxref)
> <tab>/usr/sbin/kldxref
> .endif
This whole argument ignores what the real problem is. The really
correct way to handle this is to use the kldxref(8) built in the
'buildworld' phase. (It's bad form to be using any executables from
the base system if we have a full object tree.) Actually using the one
in /usr/obj/usr/src/usr.sbin/kldxref seems pretty ugly. The better
thing to do is to have a version in /usr/obj/usr/src/<arch>/usr/sbin
by making it a crosstool. The failure should not be ignored in this
case.
--
Crist J. Clark | cjclark@alum.mit.edu
| cjclark@jhu.edu
http://people.freebsd.org/~cjc/ | cjc@freebsd.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020401111708.V99214>