Date: Tue, 19 Feb 2013 02:18:55 GMT From: Ryan Steinmetz <zi@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/176259: [openbsm][patch] praudit produces invalid XML (1.2-alpha3) Message-ID: <201302190218.r1J2ItTR038108@red.freebsd.org> Resent-Message-ID: <201302190220.r1J2K0TU043405@freefall.freebsd.org>
index | next in thread | raw e-mail
>Number: 176259
>Category: kern
>Synopsis: [openbsm][patch] praudit produces invalid XML (1.2-alpha3)
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Feb 19 02:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Ryan Steinmetz
>Release:
>Organization:
>Environment:
>Description:
OpenBSM 1.2-alpha3 contains a bug that causes it to produce invalid XML output. The following is an example of the invalid output:
<?xml version='1.0' ?>
<audit>
<record ,56,11,audit startup,0,Tue Feb 19 00:58:45 2013, + 654 msec
<text>auditd::Audit startup</text>
<return errval="success" retval="0" />
</record>
>How-To-Repeat:
Run 'praudit -x ...' on a 9-STABLE or 10-CURRENT box.
>Fix:
Apply the attached patch.
Patch attached with submission follows:
--- ./libbsm/bsm_io.c.orig 2013-02-18 21:07:28.000000000 -0500
+++ ./libbsm/bsm_io.c 2013-02-18 21:07:38.000000000 -0500
@@ -949,7 +949,7 @@
{
print_tok_type(fp, tok->id, "header", oflags);
- if (oflags & AU_OFLAG_RAW) {
+ if (oflags & AU_OFLAG_XML) {
open_attr(fp, "version");
print_1_byte(fp, tok->tt.hdr32.version, "%u");
close_attr(fp);
>Release-Note:
>Audit-Trail:
>Unformatted:
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302190218.r1J2ItTR038108>