Date: Thu, 12 Mar 1998 20:47:04 +0100 From: Eivind Eklund <eivind@yes.no> To: Terry Lambert <tlambert@primenet.com> Cc: current@FreeBSD.ORG Subject: Re: ext2_sync and NULL inode and VNON v_type Message-ID: <19980312204704.62898@follo.net> In-Reply-To: <199803121941.MAA10146@usr08.primenet.com>; from Terry Lambert on Thu, Mar 12, 1998 at 07:41:17PM %2B0000 References: <19980312134733.38685@follo.net> <199803121941.MAA10146@usr08.primenet.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 12, 1998 at 07:41:17PM +0000, Terry Lambert wrote:
> > AFAIK, it worked fine before the soft-updates integration. After the
> > soft-updates integration it didn't even _compile_. I fixed this - it
> > took three lines of changes, which I snarfed from FFS - but I haven't
> > done any testing etc, and it wouldn't surprise me if there are other,
> > more insidious problems from the integration. I just needed it to
> > compile so it wouldn't block LINT.
>
> I'm curious, but not enough to drive home during lunch. What did
> you have to change? There was not supposed to be an impact.
Here is the diff:
Index: ext2_vfsops.c
===================================================================
RCS file: /home/ncvs/src/sys/gnu/ext2fs/ext2_vfsops.c,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- ext2_vfsops.c 1998/03/01 22:45:52 1.29
+++ ext2_vfsops.c 1998/03/09 14:46:57 1.30
@@ -648,9 +648,9 @@
ump->um_seqinc = EXT2_FRAGS_PER_BLOCK(fs);
for (i = 0; i < MAXQUOTAS; i++)
ump->um_quotas[i] = NULLVP;
- devvp->v_specflags |= SI_MOUNTEDON;
- if (ronly == 0)
- ext2_sbupdate(ump, MNT_WAIT);
+ devvp->v_specmountpoint = mp;
+ if (ronly == 0)
+ ext2_sbupdate(ump, MNT_WAIT);
return (0);
out:
if (bp)
@@ -706,7 +706,7 @@
if (fs->s_block_bitmap[i])
ULCK_BUF(fs->s_block_bitmap[i])
- ump->um_devvp->v_specflags &= ~SI_MOUNTEDON;
+ ump->um_devvp->v_specmountpoint = NULL;
error = VOP_CLOSE(ump->um_devvp, ronly ? FREAD : FREAD|FWRITE,
NOCRED, p);
vrele(ump->um_devvp);
Note that some of this is whitespace change due to the old formatting
being plain wrong.
Eivind.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980312204704.62898>