Date: Sat, 28 Feb 2026 23:49:41 -0800 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> Cc: Enji Cooper <ngie@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 1f2f5eba24aa - main - asmc(4): pull 32-bit support for the driver Message-ID: <4A796B89-DBE0-4845-947E-65C5B95C0650@gmail.com> In-Reply-To: <86y0kdngqs.fsf@ltc.des.dev> References: <69a1f40e.1eb9e.56768185@gitrepo.freebsd.org> <86y0kdngqs.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
> On Feb 28, 2026, at 5:24 AM, Dag-Erling Smørgrav <des@FreeBSD.org> wrote:
>
> Enji Cooper <ngie@FreeBSD.org> writes:
>> commit 1f2f5eba24aa53e180a4eb46b772410e5a782469
>> Author: Enji Cooper <ngie@FreeBSD.org>
>> AuthorDate: 2026-01-05 03:36:55 +0000
>> Commit: Enji Cooper <ngie@FreeBSD.org>
>> CommitDate: 2026-02-27 19:44:08 +0000
>>
>> asmc(4): pull 32-bit support for the driver
>>
>> The asmc(4) driver should work for 32-bit Intel-based Macs, in theory, if
>> the model details were added to the detection list. That being said,
>> 32-bit Intel Macs were only released and available to the general public
>> for 8 months [1], so the value in maintaining i386 support in the driver is
>> reduced due to limited hardware access.
>>
>> Remove 32-bit support for the driver officially to make it clear its use is
>> not supported.
>>
>> This should fix building `NOTES.i386` by proxy as well.
>>
>> Relnotes: yes
>> MFC after: 2 weeks
>> Fixes: f224591746b ("Add ASMC_DEBUG make option")
>> Fixes: 8342d9f7b5f ("asmc(4): Stop building it on i386, as...")
>> Differential Revision: https://reviews.freebsd.org/D55544
>
> Please remember that the bugs this fixes have already been merged to
> stable/15 and stable/14.
Oof — fair. I’ll wait a 3 days instead of 2 weeks and merge.
-Enji
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmj75UACgkQGpE5DjPs
NJj0kw//QN7+H0sA4d5e8wBBkrq5NM6JOae5saXuafBSD3UvnKaolXEFUhA0u7Kl
U/hu2/S3A7M8nIgmbNPecukXhcY0aq0ivnY2Is4skTANd46yf909T649Faty8724
1O7k4PkGK2bqRUyFsGJ8SufqSwlnsoYddXYhrNQY95WEwXncb5+zsuKsGXffljC5
hCzvlQE9YvRm819B+V0IkvnA3zlsH3LWgX4aYng1cotNa2rCR+/M4G7KdbR8h+To
ub8NelSVzjD+jZiN/yjEnnT/rthUDnxYaCk4zgKWvQbZk/x8H4jBjloy72a73nzv
+gJ4e3na7/LYkZNdnRwpWdtN1fUYE8LvGgMR58oy2ZS7YlAxvk7Zh0N4W7HiCigD
YCEPxmVbmyakrb9R+OBvXRI/EmDhUlG+1z+8KsL7saNB0dwksDZjksseRnJwZ+QY
wywqq8PwfyY1CKBm+yxbMKuYBcvjuTFFcG2xgG7yxr03adLghV8JaDFD2FLv/Hca
gRpONYO9AiSm/3VF+6GVqZwha3cylu1cl4B0BKM5u7rxuHCiEAZ0PS83ZM3zFevu
ZSsP73BDrR7I08caczIxpE52S1XWZjWZi/L2DdT0oRgcPPVZXTaum+w4VJT3Ukbm
gat0ZaA4B9h0PU2zSyUqEBKhZ66KUY+Oj0REKu+SLm707kBIaic=
=zpdf
-----END PGP SIGNATURE-----
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A796B89-DBE0-4845-947E-65C5B95C0650>