Date: Sat, 4 Feb 2023 10:07:14 -0500 From: Adam Weinberger <adamw@adamw.org> To: Dmitri Goutnik <dmgk@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e41e27b19194 - main - www/caddy: Pin Go version to 1.19 Message-ID: <CAP7rwci0t_jHCLeccc6T2ijp7h40qDuKkcFMSgHKLgbZbeY9pg@mail.gmail.com> In-Reply-To: <202302031951.313Jp8eE067836@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Feb 3, 2023 at 2:51 PM Dmitri Goutnik <dmgk@freebsd.org> wrote: > The branch main has been updated by dmgk: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=e41e27b19194be93c1bad06a10dafc9211264960 > > commit e41e27b19194be93c1bad06a10dafc9211264960 > Author: Dmitri Goutnik <dmgk@FreeBSD.org> > AuthorDate: 2023-02-03 15:55:51 +0000 > Commit: Dmitri Goutnik <dmgk@FreeBSD.org> > CommitDate: 2023-02-03 18:09:08 +0000 > > www/caddy: Pin Go version to 1.19 > > vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:5:13: > cannot use "The version of quic-go you're using can't be built on Go 1.20 > yet. > > quic-go doesn't support go1.20 yet, keep building this port with go1.19 > for now. > > PR: 269289 > Reported by: exp-run > --- > www/caddy/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/caddy/Makefile b/www/caddy/Makefile > index 433acbb98efa..549ce5311644 100644 > --- a/www/caddy/Makefile > +++ b/www/caddy/Makefile > @@ -12,7 +12,7 @@ WWW= https://caddyserver.com > LICENSE= APACHE20 > LICENSE_FILE= ${WRKSRC}/LICENSE > > -USES= cpe go:modules > +USES= cpe go:1.19,modules > CPE_VENDOR= caddyserver > > USE_RC_SUBR= caddy > Thanks for doing this! In the past I've manually recreated GH_TUPLE (> 110 modules) every time Go gets a minor bump, but pinning Go until the next caddy release looks like a much better option. For anyone playing at home, some subtle path-handling semantics changed in go1.20, so it's not as simple as just bumping the quic-go dep this time. The PR is https://github.com/caddyserver/caddy/pull/5353. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 3, 2023 at 2:51 PM Dmitri Goutnik <<a href="mailto:dmgk@freebsd.org">dmgk@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by dmgk:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=e41e27b19194be93c1bad06a10dafc9211264960" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=e41e27b19194be93c1bad06a10dafc9211264960</a><br>; <br> commit e41e27b19194be93c1bad06a10dafc9211264960<br> Author: Dmitri Goutnik <dmgk@FreeBSD.org><br> AuthorDate: 2023-02-03 15:55:51 +0000<br> Commit: Dmitri Goutnik <dmgk@FreeBSD.org><br> CommitDate: 2023-02-03 18:09:08 +0000<br> <br> www/caddy: Pin Go version to 1.19<br> <br> vendor/<a href="http://github.com/lucas-clemente/quic-go/internal/qtls/go120.go:5:13" rel="noreferrer" target="_blank">github.com/lucas-clemente/quic-go/internal/qtls/go120.go:5:13</a>: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet.<br> <br> quic-go doesn't support go1.20 yet, keep building this port with go1.19<br> for now.<br> <br> PR: 269289<br> Reported by: exp-run<br> ---<br> www/caddy/Makefile | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/www/caddy/Makefile b/www/caddy/Makefile<br> index 433acbb98efa..549ce5311644 100644<br> --- a/www/caddy/Makefile<br> +++ b/www/caddy/Makefile<br> @@ -12,7 +12,7 @@ WWW= <a href="https://caddyserver.com" rel="noreferrer" target="_blank">https://caddyserver.com</a><br>; LICENSE= APACHE20<br> LICENSE_FILE= ${WRKSRC}/LICENSE<br> <br> -USES= cpe go:modules<br> +USES= cpe go:1.19,modules<br> CPE_VENDOR= caddyserver<br> <br> USE_RC_SUBR= caddy<br> </blockquote></div><div><br></div><div><div style="font-family:arial,sans-serif" class="gmail_default">Thanks for doing this! In the past I've manually recreated GH_TUPLE (> 110 modules) every time Go gets a minor bump, but pinning Go until the next caddy release looks like a much better option.</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default">For anyone playing at home, some subtle path-handling semantics changed in go1.20, so it's not as simple as just bumping the quic-go dep this time. The PR is <a href="https://github.com/caddyserver/caddy/pull/5353">https://github.com/caddyserver/caddy/pull/5353</a>.</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default"># Adam</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div></div><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Adam Weinberger</div><div><a href="mailto:adamw@adamw.org" target="_blank">adamw@adamw.org</a></div><div><a href="https://www.adamw.org" target="_blank">https://www.adamw.org</a></div></div></div></div></div></div>;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwci0t_jHCLeccc6T2ijp7h40qDuKkcFMSgHKLgbZbeY9pg>