Date: Tue, 17 Jan 2006 20:25:01 +0000 (UTC) From: Juli Mallett <jmallett@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern kern_proc.c Message-ID: <200601172025.k0HKP1EW063539@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jmallett 2006-01-17 20:25:01 UTC
FreeBSD src repository
Modified files:
sys/kern kern_proc.c
Log:
Since p_cansee will end up dereferencing p_ucred, don't check for p_ucred
equal to NULL several times later. p_ucred "should probably not" be NULL
if the process isn't PRS_NEW anyway. This is strongly reinforced by the fact
that we don't see frequent crashes here. Remove the checks after p_cansee and
add a KASSERT right before it.
Found by: Coverity Prevent (tm)
Also trim one nearby trailing space.
Revision Changes Path
1.237 +7 -9 src/sys/kern/kern_proc.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601172025.k0HKP1EW063539>