Date: Tue, 12 Apr 2005 08:36:13 +0930 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make cond.c cond.h for.c for.h parse.c parse.h Message-ID: <20050411230613.GL84649@wantadilla.lemis.com> In-Reply-To: <20050411091126.GA6125@xor.obsecurity.org> References: <200504110720.j3B7KAIx034955@repoman.freebsd.org> <20050411074021.GA85675@xor.obsecurity.org> <20050411101216.N97775@beagle.kn.op.dlr.de> <20050411091126.GA6125@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--2EnvhqpWJq810sZn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Monday, 11 April 2005 at 2:11:26 -0700, Kris Kennaway wrote: > On Mon, Apr 11, 2005 at 11:07:28AM +0200, Harti Brandt wrote: > >> KK>I assume you've tested that this doesn't cause problems for anything >> KK>in the ports collection? >> >> I didn't test all of the ports collection - just a number of ports. But I >> grepped the ports infrastructure and the ports Makefile* for problematic >> constructs and found one problem that now shows up (under certain >> conditions) instead of beeing hidden: >> >> mail/dspam >> mail/dspam-devel >> >> both of them use >> >> . elseif ... >> >> This has been intepreted by make as a plain .else without any warning up >> to now. Now it is just ignored when the .if defined (WITH_MYSQL40) ... is >> false and give an error if it is true. I'll inform the maintainer about >> this. >> >> There may be of course ports that use our make to build. In any case the >> change to the .else and .endif clauses just give a warning so the ports >> maintainer have time to fix this. What could break is the use of >> .undefFOO but I don't expect many of them. > > I really hope this doesn't cause problems, but based on historical > precedent I expect that it will. In future, please coordinate > troublesome make changes with us (portmgr) so we can test them first > and avoid destabilizing the ports collection for the users. It would be interesting to understand the necessity of this change. We have so many different flavours of make already. Greg -- See complete headers for address and phone numbers. --2EnvhqpWJq810sZn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFCWwLlIubykFB6QiMRArjVAJ0X0KROo9tZI5YIlcFXd0Gd3UanawCfV/8m 8gKgYA2Nm4ZJWsnbd/SARDg= =YDf3 -----END PGP SIGNATURE----- --2EnvhqpWJq810sZn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050411230613.GL84649>