Date: Mon, 27 Nov 2006 10:32:17 -0500 From: Mikhail Teterin <mi+kde@aldan.algebra.com> To: Norikatsu Shigemura <nork@freebsd.org> Cc: ports@freebsd.org Subject: Re: ports/devel/icu: PTHREAD_LIBS clean Message-ID: <200611271032.18366@aldan> In-Reply-To: <20061127222709.aa35ab22.nork@FreeBSD.org> References: <20061127222709.aa35ab22.nork@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 27 November 2006 08:27, Norikatsu Shigemura wrote: = Hi mi! = = I found a problem that icu don't reflect PTHREAD_LIBS=ANY(like -lthr). = Please check following patch. Thanks, I'll try it... Do you need it to be thread-aware though? It is built by default without threads at all (because threads are/were busted on FreeBSD/ia64). ICU developers think, threads ought to be enabled, but there really is no software at the moment, which calls into ICU from multiple threads at the same time, AFAIK... -mi = Index: Makefile = =================================================================== = RCS file: /home/ncvs/ports/devel/icu/Makefile,v = retrieving revision 1.24 = diff -u -r1.24 Makefile = --- Makefile 9 Nov 2006 02:55:27 -0000 1.24 = +++ Makefile 26 Nov 2006 17:10:08 -0000 = @@ -67,6 +67,7 @@ = CONFIGURE_ARGS+= --enable-threads=yes = post-patch: = ${REINPLACE_CMD} -e 's,\(THREADSC.*FLAGS\).*,\1=${PTHREAD_CFLAGS},g' ${WRKSRC}/config/mh-bsd-gcc = + ${REINPLACE_CMD} -e 's,-lpthread,${PTHREAD_LIBS},g' ${WRKSRC}/configure = .else = CONFIGURE_ARGS+= --enable-threads=no = .endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611271032.18366>