Date: Sun, 9 Dec 2001 16:25:58 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.org> To: Peter Wemm <peter@wemm.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_timer.c Message-ID: <Pine.NEB.3.96L.1011209162355.85510D-100000@fledge.watson.org> In-Reply-To: <20011208202742.8B7D83808@overcee.netplex.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 8 Dec 2001, Peter Wemm wrote: > Robert Watson wrote: > > rwatson 2001/12/07 09:01:28 PST > > > > Modified files: > > sys/netinet tcp_timer.c > > Log: > > o Our currenty userland boot code (due to rc.conf and rc.network) always > > enables TCP keepalives using the net.inet.tcp.always_keepalive by default > . > > Synchronize the kernel default with the userland default. > > It was done this way to minimize POLA. If you build/install a kernel on > its own (fairly common) then the idle connection probe (keepalive) would > not be turned on. It was something that the sysadmin had to activate > via a config file update (mergemaster, or doing it manually). > > Anyway, the change above is fine for -current, but I wanted to make sure > that the reason for the difference was known. I tried to maintain compatibility for the rc.conf entry via my follow-up commit, which relied on the fact that we already define that rc.conf variable in defaults/rc.conf. If it has been locally turned off in /etc/rc.conf, then the new rc.network script will turn off the variable and maintain compatibility. I don't currently have plans to MFC this change, but might do closer to 4.5 after some inspection of 4-STABLE's code. BTW, could whoever made kern.nmbclusters a tunable in -CURRENT consider looking at doing the same in -STABLE? It's one of the few "we recommend this tweak" entries that does require a recompile of GENERIC right now... Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1011209162355.85510D-100000>