Date: Wed, 3 Dec 2003 01:07:10 -0500 From: Mathew Kanner <mat@cnd.mcgill.ca> To: Jesse Guardiani <jesse@wingnet.net>, Sean Chittenden <seanc@FreeBSD.org>, freebsd-current@FreeBSD.org Subject: please test pcm channel patch Message-ID: <20031203060710.GJ54011@cnd.mcgill.ca>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Hello All,
Please test this PCM patch. It creates seperate locking
classes for PCM channels and should prevent the warning where multiple
mutexes from the same class are held (as reported recently). I
believe this to be a good strategy as it masks fewer errors.
Thanks,
--mat
--
The state has no business in the bedrooms of the
nation.
- Pierre Elliott Trudeau
[-- Attachment #2 --]
Index: channel.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/sound/pcm/channel.c,v
retrieving revision 1.92
diff -u -r1.92 channel.c
--- channel.c 27 Nov 2003 19:51:44 -0000 1.92
+++ channel.c 3 Dec 2003 05:59:56 -0000
@@ -69,7 +69,10 @@
static void
chn_lockinit(struct pcm_channel *c)
{
- c->lock = snd_mtxcreate(c->name, "pcm channel");
+ if (c->direction == PCMDIR_PLAY)
+ c->lock = snd_mtxcreate(c->name, "pcm play channel");
+ else
+ c->lock = snd_mtxcreate(c->name, "pcm record channel");
}
static void
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031203060710.GJ54011>