Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 27 Nov 2006 18:03:25 +0800
From:      "Earl Lapus" <earl.lapus@gmail.com>
To:        freebsd-hackers@freebsd.org
Subject:   pfctl
Message-ID:  <604f76120611270203n3d065114vdbe8487cc04357e1@mail.gmail.com>
next in thread | raw e-mail | index | archive | help 
hi,

I was browsing through some code and stumbled upon this:

...
if ((opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) ||
   (opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) ||
   (opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0)) {
   warnx("m1 must be zero for convex curve: %s", pa->qname);
   return (-1);
}
...


would it be safe to change it to:
...
if (opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) {
   warnx("m1 must be zero for convex curve: %s", pa->qname);
   return (-1);
}
...

-OR- is there something between those lines that I'm missing.

The piece of code that I'm referring to is found in
/usr/src/contrtib/pf/pfctl/pfctl_altq.c





-- 
There are seven words in this sentence.

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?604f76120611270203n3d065114vdbe8487cc04357e1>