Date: Thu, 12 Jun 2025 02:56:21 +0000 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Warner Losh <imp@freebsd.org>, Ricardo Branco <rbranco@suse.de> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3d12567133bf - main - Add the POSIX sig2str(3) & str2sig(3) calls Message-ID: <ngi7bslz4knvlxm2x53mc6uyf5capuyb6pvftwwczfdv2nhjp2@ybinoxkw6vyc> In-Reply-To: <202506112316.55BNGeGh046207@gitrepo.freebsd.org> References: <202506112316.55BNGeGh046207@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--hpe22asn2yxz7nsz Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: 3d12567133bf - main - Add the POSIX sig2str(3) & str2sig(3) calls MIME-Version: 1.0 On Wed, Jun 11, 2025 at 11:16:40PM +0000, Warner Losh wrote: > The branch main has been updated by imp: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D3d12567133bfb4082a5115f16a= 71a865ff2af7fb >=20 > commit 3d12567133bfb4082a5115f16a71a865ff2af7fb > Author: Ricardo Branco <rbranco@suse.de> > AuthorDate: 2025-05-10 20:56:03 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2025-06-11 23:16:22 +0000 >=20 > Add the POSIX sig2str(3) & str2sig(3) calls > =20 > Signed-off-by: Ricardo Branco <rbranco@suse.de> > Reviewed by: imp, kib, des, jilles > Pull Request: https://github.com/freebsd/freebsd-src/pull/1696 > --- > include/signal.h | 9 ++++ > lib/libc/gen/Makefile.inc | 3 ++ > lib/libc/gen/Symbol.map | 2 + > lib/libc/gen/psignal.3 | 56 ++++++++++++++++++++++- > lib/libc/gen/sig2str.c | 112 ++++++++++++++++++++++++++++++++++++++++= ++++++ > 5 files changed, 180 insertions(+), 2 deletions(-) >=20 > diff --git a/include/signal.h b/include/signal.h > index c1d341f317f4..22fefb63568f 100644 > --- a/include/signal.h > +++ b/include/signal.h > @@ -40,6 +40,10 @@ > #include <sys/_ucontext.h> > #endif > =20 > +#if __POSIX_VISIBLE >=3D 202405 || __BSD_VISIBLE > +#define SIG2STR_MAX 32 /* size of buffer required for sig2str() */ > +#endif Hey Warner and Ricardo, The above breaks building world when _FORTIFY_SOURCE=3D2. I've committed in HardenedBSD a fix: https://git.hardenedbsd.org/hardenedbsd/HardenedBSD/-/commit/0572db282c5a54= 2fe0de52739932e91eade537ed I suppose that the !defined gate might not actually be desired, since doing it the way I did might cause issues if third-party code defines the macro to a value smaller than what libc was built with. I might remove that gate. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --hpe22asn2yxz7nsz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmhKQcMACgkQ/y5nonf4 4frPTxAAhubTBLXKz3JzOES74yOFCKtyfGx1oyslx50HVYiYJzIlfiEV8vJ8t7dH opd9gI0ENndtm8PMduEtabQArMIAGobpSux1zsfifIydGerOgZpFx1fZUj5/f5yQ V5t0E0s0ekcsQhmes6rw0jQ3NDbdQFQHNoa5zZD/ggaUeuvLked3vYC9aX2P1QDr 1PGUW0h3CrrURLp+JD+hemQKsceE9uZBnAx3cZpjVzeorbc5rULyqEbuxecJ2/Il 1b/JwyUSX9/pmuRZUhSrtit3AzuLbHxgcJoB0JdMlym5qhbuTUexRbxLDInYwN16 x/bgpVAD4N8un6Mx8yM8VMv4lX+Z6T1dmkGoxR1s+bto6/ZVxBrr2N2UXSaozzDf c90V+2lLs8eLZFsDJPJMjcWSNhkFHQtcsHd4q8PBuYIaisI/EKPakyeSj7obtTwo WS3Oqwp/FDy9i2ft4hqRdcUCPn/CoQGDwVgLjrERQBkmqcXHgq7w5CHX+SOENwt6 G5dLDb41BbeFGnxFwAV56TPv0SzYsli4f22gOtxoAu16789HIuE83j6LUFvCBa89 Gpr6g0AvJb1/A8n7atwpi3uxB2OCZ43Gq+YLnOSE2KbBHk+opsIR9Tlnry/Ylm6X MJeQy76nw1zs9L9/VR4lHt1CRrclRKzv43DQmXfcEbjvv5sn/24= =cvQ6 -----END PGP SIGNATURE----- --hpe22asn2yxz7nsz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ngi7bslz4knvlxm2x53mc6uyf5capuyb6pvftwwczfdv2nhjp2>