Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Feb 2020 20:13:29 +0000
From:      bugzilla-noreply@freebsd.org
To:        x11@FreeBSD.org
Subject:   [Bug 243649] [patch] devel/libepoll-shim: Update to 0.0.20191117 version to unbreak re-plugging input devices
Message-ID:  <bug-243649-7141-WkRedX6enj@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-243649-7141@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243649

--- Comment #16 from Michael Gmelin <grembo@FreeBSD.org> ---
(In reply to Jan Beich from comment #14)

> Why not simplify into the following then run "make makesum"?
> Whoever updates next then only needs to check if your PR was merged:

I left a comment in the patch. I didn't want to rely on the hash
of a commit that might not get merged exactly like it is/end up
somehow butchered in github for the build.

> Looks ugly but so is checking getrlimit(RLIMIT_NOFILE) in source

I spent like an hour trying to find a solution that looks
nice/readable... (all the other options were worse) ¯\_(ツ)_/¯

> Prepend ${TEST_ENV} before ctest command to sanitize HOME.

Like in "${SETENV} ${TEST_ENV} ctest..."?

-- 
You are receiving this mail because:
You are the assignee for the bug.

help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-243649-7141-WkRedX6enj>