Date: Thu, 15 Jan 2009 11:44:08 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: stas@FreeBSD.org, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, gonzo@FreeBSD.org Subject: Re: svn commit: r187251 - head/sys/mips/malta Message-ID: <20090115114407.GA67726@FreeBSD.org> In-Reply-To: <20090114.190527.1058804377.imp@bsdimp.com> References: <200901142232.n0EMWhGw055895@svn.freebsd.org> <20090115020752.52566769.stas@FreeBSD.org> <20090114.190527.1058804377.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 14, 2009 at 07:05:27PM -0700, M. Warner Losh wrote: > In message: <20090115020752.52566769.stas@FreeBSD.org> > Stanislav Sedov <stas@FreeBSD.org> writes: > : > + shift = 8 * (reg & 3); > : > > : > : Would it make sense to replace this with > : > + shift = (reg & 3) << 3; > : > : to not rely on possible compiler optimizations? > > I don't think that it matters all that much these days... But the name "shift" kinda suggests << instead of *, no? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090115114407.GA67726>