Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 Nov 2008 20:17:17 +0000 (UTC)
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r185229 - in head/tools/regression/fstest/tests: chown rename unlink
Message-ID:  <200811232017.mANKHHHU063156@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pjd
Date: Sun Nov 23 20:17:17 2008
New Revision: 185229
URL: http://svn.freebsd.org/changeset/base/185229

Log:
  Mark all the places where Linux is not POSIX-compilant. Tested on ext3.

Modified:
  head/tools/regression/fstest/tests/chown/00.t
  head/tools/regression/fstest/tests/rename/21.t
  head/tools/regression/fstest/tests/unlink/08.t

Modified: head/tools/regression/fstest/tests/chown/00.t
==============================================================================
--- head/tools/regression/fstest/tests/chown/00.t	Sun Nov 23 20:14:19 2008	(r185228)
+++ head/tools/regression/fstest/tests/chown/00.t	Sun Nov 23 20:17:17 2008	(r185229)
@@ -238,6 +238,7 @@ ctime1=`${fstest} stat ${n0} ctime`
 sleep 1
 expect 0 -- chown ${n0} -1 -1
 ctime2=`${fstest} stat ${n0} ctime`
+todo Linux "According to POSIX: If both owner and group are -1, the times need not be updated."
 test_check $ctime1 -eq $ctime2
 expect 0 unlink ${n0}
 # 158
@@ -246,6 +247,7 @@ ctime1=`${fstest} stat ${n0} ctime`
 sleep 1
 expect 0 -- chown ${n0} -1 -1
 ctime2=`${fstest} stat ${n0} ctime`
+todo Linux "According to POSIX: If both owner and group are -1, the times need not be updated."
 test_check $ctime1 -eq $ctime2
 expect 0 rmdir ${n0}
 # 162
@@ -254,6 +256,7 @@ ctime1=`${fstest} stat ${n0} ctime`
 sleep 1
 expect 0 -- chown ${n0} -1 -1
 ctime2=`${fstest} stat ${n0} ctime`
+todo Linux "According to POSIX: If both owner and group are -1, the times need not be updated."
 test_check $ctime1 -eq $ctime2
 expect 0 unlink ${n0}
 # 166
@@ -262,6 +265,7 @@ ctime1=`${fstest} lstat ${n0} ctime`
 sleep 1
 expect 0 -- lchown ${n0} -1 -1
 ctime2=`${fstest} lstat ${n0} ctime`
+todo Linux "According to POSIX: If both owner and group are -1, the times need not be updated."
 test_check $ctime1 -eq $ctime2
 expect 0 unlink ${n0}
 

Modified: head/tools/regression/fstest/tests/rename/21.t
==============================================================================
--- head/tools/regression/fstest/tests/rename/21.t	Sun Nov 23 20:14:19 2008	(r185228)
+++ head/tools/regression/fstest/tests/rename/21.t	Sun Nov 23 20:17:17 2008	(r185229)
@@ -37,9 +37,12 @@ expect ENOENT rmdir ${n3}/${n1}
 # Check that write permission on containing directory (${n2}) is enough
 # to move file (${n0}) from that directory.
 expect 0 create ${n2}/${n0} 0755
+todo Linux "According to POSIX, write access to ${n2}/${n0} and (if exists) ${n3}/${n1} may be required if ${n0} and (if exists) ${n1} are directories, not regular files."
 expect 0 -u 65534 -g 65534 rename ${n2}/${n0} ${n3}/${n1}
 
+todo Linux "According to POSIX, write access to ${n2}/${n0} and (if exists) ${n3}/${n1} may be required if ${n0} and (if exists) ${n1} are directories, not regular files."
 expect 0 unlink ${n3}/${n1}
+todo Linux "According to POSIX, write access to ${n2}/${n0} and (if exists) ${n3}/${n1} may be required if ${n0} and (if exists) ${n1} are directories, not regular files."
 expect ENOENT unlink ${n2}/${n0}
 
 expect 0 rmdir ${n3}

Modified: head/tools/regression/fstest/tests/unlink/08.t
==============================================================================
--- head/tools/regression/fstest/tests/unlink/08.t	Sun Nov 23 20:14:19 2008	(r185228)
+++ head/tools/regression/fstest/tests/unlink/08.t	Sun Nov 23 20:17:17 2008	(r185229)
@@ -11,5 +11,6 @@ echo "1..3"
 n0=`namegen`
 
 expect 0 mkdir ${n0} 0755
+todo Linux "According to POSIX: EPERM - The file named by path is a directory, and either the calling process does not have appropriate privileges, or the implementation prohibits using unlink() on directories."
 expect "0|EPERM" unlink ${n0}
 expect "0|ENOENT" rmdir ${n0}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811232017.mANKHHHU063156>