Date: Thu, 22 Aug 2019 14:27:20 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351406 - head/sys/dev/nvme Message-ID: <bcd7d7cc-a79f-98a1-49b1-8868bfc64818@FreeBSD.org> In-Reply-To: <201908222112.x7MLCpbt023647@repo.freebsd.org> References: <201908222112.x7MLCpbt023647@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/22/19 2:12 PM, Warner Losh wrote: > Author: imp > Date: Thu Aug 22 21:12:51 2019 > New Revision: 351406 > URL: https://svnweb.freebsd.org/changeset/base/351406 > > Log: > We need to define version 1 of nvme, not nvme_foo. Otherwise nvd won't > load and people who pull in nvme/nvd from modules can't load nvd.ko > since it depends on nvme, not nvme_foo. The duplicate doesn't matter > since kldxref properly handles that case. I would perhaps have put the MODULE_VERSION for nvme and its dependency on cam into nvme.c instead of duplicating it. I think that is more consistent with what we have done elsewhere in the tree. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bcd7d7cc-a79f-98a1-49b1-8868bfc64818>