Date: Tue, 10 Feb 2009 17:09:47 -0500 From: Coleman Kane <cokane@FreeBSD.org> To: Marius Strobl <marius@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r188457 - head/sys/dev/bge Message-ID: <1234303787.10699.4.camel@localhost> In-Reply-To: <200902102154.n1ALsNCh005356@svn.freebsd.org> References: <200902102154.n1ALsNCh005356@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, 2009-02-10 at 21:54 +0000, Marius Strobl wrote: > Author: marius > Date: Tue Feb 10 21:54:23 2009 > New Revision: 188457 > URL: http://svn.freebsd.org/changeset/base/188457 > > Log: > Don't reset the PHY probe retry counter within the loop so > it will eventually terminate as intended. > > Submitted by: Helen Zhang > > Modified: > head/sys/dev/bge/if_bge.c > > Modified: head/sys/dev/bge/if_bge.c > ============================================================================== > --- head/sys/dev/bge/if_bge.c Tue Feb 10 21:51:33 2009 (r188456) > +++ head/sys/dev/bge/if_bge.c Tue Feb 10 21:54:23 2009 (r188457) > @@ -2674,11 +2674,11 @@ bge_attach(device_t dev) > * if we get a conflict with the ASF firmware accessing > * the PHY. > */ > + trys = 0; > BGE_CLRBIT(sc, BGE_MODE_CTL, BGE_MODECTL_STACKUP); > again: > bge_asf_driver_up(sc); > > - trys = 0; > if (mii_phy_probe(dev, &sc->bge_miibus, > bge_ifmedia_upd, bge_ifmedia_sts)) { > if (trys++ < 4) { > I'm curious... I recent ran into a problem where this driver was not properly recovering from an ACPI resume event (under amd64 with some patches). I am curious if this patch might fix that problem... as the death happened somewhere around here. What example case did you use to discover this bug? -- Coleman Kane [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkmR+ycACgkQcMSxQcXat5cCJgCfcSG2qSKkgnxWLwe3oC/Mnkxp JngAn0uyMSsaDiMUwhpEKtNM/xFr4jo9 =6CH1 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1234303787.10699.4.camel>