Date: Tue, 26 Aug 2014 15:03:13 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: "current@freebsd.org" <current@freebsd.org>, FreeBSD CURRENT <freebsd-current@freebsd.org>, Harald Schmalzbauer <h.schmalzbauer@omnilan.de>, Mark Johnston <markj@freebsd.org>, "net@freebsd.org" <net@freebsd.org>, Yuri <yuri@rawbw.com> Subject: Re: [PATCH] Packet loss when 'control' messages are present with large data (sendmsg(2)) Message-ID: <CAJ-Vmon6=sA4pV%2BZqBqoepSA9wAZ%2BxZvgmZ7QH8uvYqOp1wRwg@mail.gmail.com> In-Reply-To: <CAOtMX2i2XRp00enpNNEft3Yh23vqqZafAjJ8t0TkBZPHAzUnHQ@mail.gmail.com> References: <522300E3.6050303@rawbw.com> <2204059.7tqSNWvxzC@ralph.baldwin.cx> <CAOtMX2gkUBPOc4o4qRbUTdv_YOiQOVDuxXBkQZEAiez6i07NAg@mail.gmail.com> <201408261515.32146.jhb@freebsd.org> <20140826195140.GA10143@charmander.home> <CAOtMX2i2XRp00enpNNEft3Yh23vqqZafAjJ8t0TkBZPHAzUnHQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26 August 2014 14:22, Alan Somers <asomers@freebsd.org> wrote: > On Tue, Aug 26, 2014 at 1:51 PM, Mark Johnston <markj@freebsd.org> wrote: >> On Tue, Aug 26, 2014 at 03:15:31PM -0400, John Baldwin wrote: >>> On Tuesday, August 26, 2014 11:05:12 am Alan Somers wrote: >>> > On Mon, Aug 25, 2014 at 1:52 PM, John Baldwin <jhb@freebsd.org> wrote= : >>> > > On Friday, August 22, 2014 01:34:28 PM Harald Schmalzbauer wrote: >>> > >> Bez=C3=BCglich Yuri's Nachricht vom 02.09.2013 06:54 (localtime): >>> > >> > Please check in this patch: >>> > >> > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D181741 >>> > >> > Please MFC into 9.X >>> > >> > >>> > >> > Description of the problem is within PR. >>> > >> > >>> > >> > Thanks, >>> > >> > Yuri >>> > >> >>> > >> Hello, >>> > >> >>> > >> I guess this fix should make it into 10.1. >>> > >> Can someone check please? >>> > > >>> > > A fix has to make into HEAD first. I've cc'd Alan who responded to= the bug. >>> > > Alan, note that glebius@ already committed the test case to HEAD a = while ago. >>> > >>> > First, Gleb's testcase needs to be converted to ATF. This would be a >>> > good exercise for anybody who's new to ATF and wants some practice. >>> > Anybody interested? >>> >>> While that would be nice, I don't know that it's quite fair to require = the >>> test to be converted before working on a possible fix. The existing te= st >>> doesn't seem that hard to run by hand: >>> >>> % cd work/freebsd/head/tools/regression/sockets/unix_passfd/ >>> % make >>> ... >>> % > ./unix_passfd >>> beginning test1-simplesendfd >>> test1-simplesendfd passed >>> ... >>> beginning test8-rigths+creds+payload >>> unix_passfd: test8-rigths+creds+payload: recvmsg: 24 bytes received >>> >>> I only say this because in the bug followup you seemed to have describe= d a >>> possible solution so it seems that you would be able to develop a fix q= uicker >>> than other folks since you are already familiar with the issues involve= d. >>> (Also, you've fixed other related issues recently.) >> >> As it happens, I went ahead and did this anyway: >> https://reviews.freebsd.org/D689 > > BTW, is it just me, or is arcanist insanely slow? Usually "arc diff > --create" or "arc diff --update" take many minutes to complete. Like, > 30 minutes. I've been trying to do "arc patch" for nearly an hour > now, but it hasn't completed yet. It's you. it's very quick for me. -a
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmon6=sA4pV%2BZqBqoepSA9wAZ%2BxZvgmZ7QH8uvYqOp1wRwg>