Date: Thu, 17 Jan 2002 08:49:24 -0800 From: "Bruce A. Mah" <bmah@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, oberman@es.net Subject: Re: cvs commit: src/sys/dev/sio sio.c Message-ID: <200201171649.g0HGnOD23179@bmah.dyndns.org> In-Reply-To: <200201171616.g0HGGqn13750@freefall.freebsd.org> References: <200201171616.g0HGGqn13750@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
If memory serves me right, Warner Losh wrote:
> imp 2002/01/17 08:16:52 PST
>
> Modified files:
> sys/dev/sio sio.c
> Log:
> While I'm not sure that I like the wording of the BIOS message in the
> previous commit, it should always print due to lack of {} around the
> second line in the if statement. The message should likely say
> something more like "There's no hardware responding at this IRQ.
> Device not present (or disbaled)," but that is too long.
Pointy hat to: bmah
I even tested this patch (I bet nobody's going to believe that one!),
and somehow missed the output in dmesg. :-(
> We generally
> don't give elementary advise in device driver messages anyway. Be
> that as it may, the problem with it printing all the time should be
> corrected.
It's a support issue. I don't object real strongly to backing out the
"port may be disabled" message but the way that the sio probe claimed a
disabled port was really an 8250 was pretty bogus and has bitten a bunch
of people (me included). So I think that some form of the second hunk
of the patch should stay in.
Bruce.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201171649.g0HGnOD23179>