Date: Thu, 7 Nov 2013 08:55:28 -0700 From: Alan Somers <asomers@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r252481 - in head: etc sbin/devd Message-ID: <CAOtMX2hLX1ZFgnqN5-6rY9SdkOHVb9yyGPNeRvEk6pyZ53TcsA@mail.gmail.com> In-Reply-To: <527B8357.5070200@FreeBSD.org> References: <201307012120.r61LKIxI059332@svn.freebsd.org> <527B8357.5070200@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 7, 2013 at 5:11 AM, Andriy Gapon <avg@freebsd.org> wrote: > > First, apologies for this very delayed reaction. > > on 02/07/2013 00:20 Alan Somers said the following: >> Author: asomers >> Date: Mon Jul 1 21:20:17 2013 >> New Revision: 252481 >> URL: http://svnweb.freebsd.org/changeset/base/252481 >> >> Log: >> Add syslog(3) support to devd(8). >> > [snip] >> @@ -243,8 +244,7 @@ bool >> action::do_action(config &c) >> { >> string s =3D c.expand_string(_cmd.c_str()); >> - if (Dflag) >> - fprintf(stderr, "Executing '%s'\n", s.c_str()); >> + devdlog(LOG_NOTICE, "Executing '%s'\n", s.c_str()); > > My opinion that this message does not deserve LOG_NOTICE message. > > LOG_NOTICE Conditions that are not error conditions, but should p= ossi=E2=80=90 > bly be handled specially. > > I don't think that devd reacting to an event deserves any special handlin= g from > an administrator. All LOG_NOTICE messages are logged into /var/log/messa= ges by > default. > Besides, many actions already explicitly call logger(1) and sometimes tha= t's the > only thing that they do. > > So on a system with default syslog configuration one can see messages lik= e: > devd: Executing 'logger Unknown USB device: vendor 0x03f0 product 0x102a = bus uhub7' > root: Unknown USB device: vendor 0x03f0 product 0x102a bus uhub7 > > I think that LOG_INFO should be fine for these messages. Yep, I agree. LOG_INFO should be fine. > >> my_system(s.c_str()); >> return (true); >> } > >> @@ -1078,10 +1090,27 @@ gensighand(int) >> romeo_must_die =3D 1; >> } >> >> +/* >> + * Local logging function. Prints to syslog if we're daemonized; syslo= g >> + * otherwise. >> + */ > > Minor nit: there is a typo in this comment. Oops. Would you like me to make these changes, or will you take care of it? -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2hLX1ZFgnqN5-6rY9SdkOHVb9yyGPNeRvEk6pyZ53TcsA>