Date: Tue, 21 Feb 2017 10:07:49 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org>, Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r313878 - head/sys/kern Message-ID: <7cd90b98-8749-a775-b5f2-3961e59bf5ed@FreeBSD.org> In-Reply-To: <56ca9623-dc6f-41fc-ba81-e7486a4ba8e3@FreeBSD.org> References: <201702171540.v1HFeOAs074991@repo.freebsd.org> <e7d7c961-ec3b-22bc-445e-abe56e421e5c@FreeBSD.org> <7da9caa5-d938-d2d0-1228-0e8897dc5632@FreeBSD.org> <56ca9623-dc6f-41fc-ba81-e7486a4ba8e3@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On 2/21/2017 2:11 AM, Andriy Gapon wrote: > On 21/02/2017 02:42, Pedro Giffuni wrote: >> FWIW, >> >> >> On 2/20/2017 7:24 PM, Bryan Drewery wrote: >>> On 2/17/2017 7:40 AM, Mateusz Guzik wrote: >>>> Author: mjg >>>> Date: Fri Feb 17 15:40:24 2017 >>>> New Revision: 313878 >>>> URL: https://svnweb.freebsd.org/changeset/base/313878 >>>> >>>> Log: >>>> mtx: get rid of file/line args from slow paths if they are unused >>>> This denotes changes which went in by accident in r313877. >>> I really wish people would just revert their changes and recommit them >>> properly. The 'svn blame' on the code in r313877 will never show the >>> commit message here (r313878). So a person would only find this >>> explanation if they read 'svn log' on the file, which in the case of >>> sys/kern/kern_mutex.c there are 273 commits for. Are we expected to >>> read 'svn log' (in the future) for all changes in the hopes that a later >>> commit happens to mention it? >>> >>> As someone who so often is 'svn blame'ing code to understand it better >>> and to track regressions, commits like this that explain other commits >>> might as well have never been done. >> As I mentioned in another thread, other svn configurations (ASF, for example) >> permit editing the log message: >> >> http://help.collab.net/index.jsp?topic=/faq/changelog.html > How well do various svn exporters handle that? > Specifically, svn-> git ? > Good point: it doesn't. The change gets ignored but it doesn't break the converter. At least not immediately, the github converter in AOO breaks frequently but it is probably unrelated. Pedro.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7cd90b98-8749-a775-b5f2-3961e59bf5ed>