Date: Thu, 25 Oct 2001 17:53:14 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@FreeBSD.org> Cc: <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/i386/i386 genassym.c machdep.c swtch.s sys_machdep.c vm_machdep.c src/sys/i386/include pcb.h pcb_ext.h proc.h Message-ID: <20011025173143.M77185-100000@delplex.bde.org> In-Reply-To: <200110250053.f9P0riv70542@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 24 Oct 2001, John Baldwin wrote: > jhb 2001/10/24 17:53:44 PDT > > Modified files: > sys/i386/i386 genassym.c machdep.c swtch.s > sys_machdep.c vm_machdep.c > sys/i386/include pcb.h pcb_ext.h proc.h > Log: > Split the per-process Local Descriptor Table out of the PCB and into > struct mdproc. > > Submitted by: Andrew R. Reiter <arr@watson.org> > Silence on: -current I was waiting for a review, or at least an rationale for this change. Why? It seems to mainly pessimize things by adding an indirection or two. Not long ago, and still in RELENG_4, it would have saved indirections, because p->p_md was direct and p->p_addr was indirect, but now both td->td_pcb and td->td_proc->p_md are indirect. Similarly for moving whole user area or whole pcb into p_md. It would have saved lots of indirections but would now add a few indirections or a lot of indirections (depending on how well you load &td->td_proc->p_md into a register; note that gcc can't optimize multiple references to td->td_proc into a single load because of aliasing problems). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011025173143.M77185-100000>