Date: Thu, 30 Sep 2010 02:11:01 -0700 From: Stanislav Sedov <stas@FreeBSD.org> To: Pav Lucistnik <pav@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Bernhard Froehlich <decke@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/zfsnap Makefile distinfo Message-ID: <20100930021101.26c36286.stas@FreeBSD.org> In-Reply-To: <4CA4505F.1080306@FreeBSD.org> References: <201009291312.o8TDCTwo029078@repoman.freebsd.org> <20100929165421.70c8064a.stas@FreeBSD.org> <4CA4505F.1080306@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, 30 Sep 2010 10:54:55 +0200 Pav Lucistnik <pav@FreeBSD.org> mentioned: > > > > It's usually beneficial if you also provide the short changelog of changes > > in the software, or at least a link to the changelog. Especially in this > > case, when maintainer wrote it clearly in the PR. > > It's not an usual practice. > Unfortunately. But it's a good one to follow, and we used to do this some time ago. > > Again, it's not a usual practice to have this in the Makefiles so the > cleanup is understandable. I understand the cleanup reason, and actually all hands for this, but the change should be mentioned in the commit message. -- Stanislav Sedov ST4096-RIPE [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJMpFQpAAoJEL8lojEJL9nwJNUQAKDApaNcQwIKpfn+tmuGx2wR CcbFXF6DFeASRBKl+ZlIFP2AbamwjzMbZYaRQQriMyU1Q8Ta/s9FCrykfXNGy6gp gvwcZ0amS+L9EFcrTPhE63CA3jTogMf5J7eTVS9tVl2zhZe27aoZHUTRR70Jab2H Wq3G9hYS/jhxjSoB92qszaf1sC6Zh5zwPWt+8muF8E2qHD86vfDssqTwQiFKPGSz EpKiMP5krJFWxVKPyDhCtQaxUfoohkCpln97Wq7kThhLiAMQO7xKKsckogbciZmt eRQ/5Ih5tMuZFeQv6j9oG+FSZyVK9RL4X44nVgbC9FOdr2DvwbK0FFOpVDNBohuu mmwkoPXUiVLUi1r0mAiUKiiORdIFx2fsfh0UGjKI5/ENiBUKreRkjApbrlWUz4A4 SzX1ECFaVwJovNrUdjWn2+HxXJbKvdFuMCw+KPKiIjKZXPEm7OWjD2AmjQzmpLao vLKlRTC67uPbM7lNeNs9iEPY0KvROhvgYa91IdpVb9sH474j5o0wq+z+MAteTrRL USiIES/D4lFThlJicAGcC7YsYHYFgdQV9FcMFNMG8OuoBsUZN1BL1UjrlMtlxFip vx6/Vv/Q7mSss9rkzuvIYyHfDBbXDKJao5etPnqbzE1r3usBWrUh0YNHzT5Gh7si rAwfhxm2z69n9+rkhWXe =K0HE -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100930021101.26c36286.stas>