Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Aug 2022 18:22:08 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 75ce327a2c43 - main - bhyve: Use "void" instead of empty parameter lists
Message-ID:  <202208161822.27GIM8N1028703@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=75ce327a2c433e793cc15861944955396ef3306b

commit 75ce327a2c433e793cc15861944955396ef3306b
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2022-08-16 17:10:58 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2022-08-16 18:21:44 +0000

    bhyve: Use "void" instead of empty parameter lists
    
    MFC after:      1 week
    Sponsored by:   The FreeBSD Foundation
---
 usr.sbin/bhyve/pci_emul.c     | 2 +-
 usr.sbin/bhyve/pci_emul.h     | 2 +-
 usr.sbin/bhyve/pci_lpc.c      | 2 +-
 usr.sbin/bhyve/pci_lpc.h      | 2 +-
 usr.sbin/bhyve/pci_passthru.c | 3 ++-
 5 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/usr.sbin/bhyve/pci_emul.c b/usr.sbin/bhyve/pci_emul.c
index 9bcd3223007a..2a79abdfdc12 100644
--- a/usr.sbin/bhyve/pci_emul.c
+++ b/usr.sbin/bhyve/pci_emul.c
@@ -321,7 +321,7 @@ done:
 }
 
 void
-pci_print_supported_devices()
+pci_print_supported_devices(void)
 {
 	struct pci_devemu **pdpp, *pdp;
 
diff --git a/usr.sbin/bhyve/pci_emul.h b/usr.sbin/bhyve/pci_emul.h
index b8cfabefda2b..14a8fe936341 100644
--- a/usr.sbin/bhyve/pci_emul.h
+++ b/usr.sbin/bhyve/pci_emul.h
@@ -253,7 +253,7 @@ int	pci_msix_pba_bar(struct pci_devinst *pi);
 int	pci_msi_maxmsgnum(struct pci_devinst *pi);
 int	pci_parse_legacy_config(nvlist_t *nvl, const char *opt);
 int	pci_parse_slot(char *opt);
-void    pci_print_supported_devices();
+void    pci_print_supported_devices(void);
 void	pci_populate_msicap(struct msicap *cap, int msgs, int nextptr);
 int	pci_emul_add_msixcap(struct pci_devinst *pi, int msgnum, int barnum);
 int	pci_emul_msix_twrite(struct pci_devinst *pi, uint64_t offset, int size,
diff --git a/usr.sbin/bhyve/pci_lpc.c b/usr.sbin/bhyve/pci_lpc.c
index 5c3aa238f43d..ef65198b63b8 100644
--- a/usr.sbin/bhyve/pci_lpc.c
+++ b/usr.sbin/bhyve/pci_lpc.c
@@ -143,7 +143,7 @@ done:
 }
 
 void
-lpc_print_supported_devices()
+lpc_print_supported_devices(void)
 {
 	size_t i;
 
diff --git a/usr.sbin/bhyve/pci_lpc.h b/usr.sbin/bhyve/pci_lpc.h
index 9041f79c507a..611b025d4386 100644
--- a/usr.sbin/bhyve/pci_lpc.h
+++ b/usr.sbin/bhyve/pci_lpc.h
@@ -68,7 +68,7 @@ struct lpc_sysres {
 #define	SYSRES_MEM(base, length)	LPC_SYSRES(LPC_SYSRES_MEM, base, length)
 
 int	lpc_device_parse(const char *opt);
-void    lpc_print_supported_devices();
+void    lpc_print_supported_devices(void);
 char	*lpc_pirq_name(int pin);
 void	lpc_pirq_routed(void);
 const char *lpc_bootrom(void);
diff --git a/usr.sbin/bhyve/pci_passthru.c b/usr.sbin/bhyve/pci_passthru.c
index f4b532ed101e..42a2f706933d 100644
--- a/usr.sbin/bhyve/pci_passthru.c
+++ b/usr.sbin/bhyve/pci_passthru.c
@@ -117,7 +117,8 @@ msi_caplen(int msgctrl)
 }
 
 static int
-pcifd_init() {
+pcifd_init(void)
+{
 	pcifd = open(_PATH_DEVPCI, O_RDWR, 0);
 	if (pcifd < 0) {
 		warn("failed to open %s", _PATH_DEVPCI);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202208161822.27GIM8N1028703>