Date: Sun, 25 Oct 2020 10:03:55 -0500 From: Kyle Evans <kevans@freebsd.org> To: Stefan Esser <se@freebsd.org> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Warner Losh <imp@bsdimp.com>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r366962 - in head: include usr.bin/calendar Message-ID: <CACNAnaEa4ZCJeU001ESkVrzqDA0kWbEk3HqBGE_xXQbt3BQ=sA@mail.gmail.com> In-Reply-To: <d52f900d-4f0f-fd26-a02e-1aa4777a062f@freebsd.org> References: <202010250346.09P3kTVH076745@gndrsh.dnsmgr.net> <d52f900d-4f0f-fd26-a02e-1aa4777a062f@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 25, 2020 at 5:21 AM Stefan Esser <se@freebsd.org> wrote: > > Am 25.10.20 um 04:46 schrieb Rodney W. Grimes: > >> On Sat, Oct 24, 2020 at 8:51 PM Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> > >> wrote: > >>>> +#define _PATH_LOCALBASE "/usr/local" > >>>> + > >>> > >>> Something feels very wrong about this becoming a defined path in base, > >>> it is further dependence on /usr/local which in the early days we spent > >>> a great deal of time removing. > >>> > >>> I believe the whole ports system allows this to be something other > >>> than /usr/local. Package should also allow it to be some other place. > >>> > >> > >> This removes a couple of instances of /usr/local being hardcoded and > >> replaces with a define, so net it's better. > > > > No, its net worse as it now creates a define that is highly likely > > to propogate adding additional dependencies on this value. > > > >> > >> It could be even better, but this is slightly better than it was before. > > > > I disagree, as it is now easier for additional contamination of > > the base system. > > There already are places that hard-code /usr/local, and I do agree > that this is architecturally bad, if you want to keep the base system > and ports as independent from each other as possible. > > But I do disagree that this was worse than before, and I'd even consider > replacing other verbatim occurrences of /usr/local with _PATH_LOCALBASE > in our sources (but not introduce new references to LOCALBASE in base). > > This would simplify a grep for such source files, for example, and also > to build base for systems with modified LOCALBASE. > > The following C header files in base (ignoring contrib) contain the > string /usr/local: > > ... > sys/contrib/openzfs/include/sys/lua/luaconf.h (FreeBSD specific?) > ... I see that you've excluded sys/contrib from the initial review, but I would not bother with luaconf.h in particular. These definitions just come from a stock Lua 5.2 and are not used in a ZFS context, they've ripped out loadlib and anything else that could try. Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaEa4ZCJeU001ESkVrzqDA0kWbEk3HqBGE_xXQbt3BQ=sA>