Date: Wed, 06 Feb 2002 23:41:56 +0000 From: Mark Murray <mark@grondar.za> To: Dag-Erling Smorgrav <des@ofug.org> Cc: current@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Not committing WARNS settings... Message-ID: <200202062342.g16Ng1s34852@greenpeace.grondar.org> In-Reply-To: <xzpzo2m5iai.fsf@flood.ping.uio.no> ; from Dag-Erling Smorgrav <des@ofug.org> "06 Feb 2002 23:58:45 %2B0100." References: <xzpzo2m5iai.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
> "David O'Brien" <obrien@FreeBSD.org> writes: > > Well... it would be nice if people would do CORRECT fixes. From > > some things DES was saying, people are making some really stupid "fixes" > > just to quite warnings. Esp. WRT const. > > Yes, the YP code is full of strdup()s that have no purpose other than > to silence const warnings, and the allocated memory is never freed - > nor is the return value from strdup() checked. Some strdup()s are ok. if they are definitely one-offs, then they are no worse than "char foo[BAR]" for some value of BAR. Others can be downright evil. M -- o Mark Murray \_ FreeBSD Services Limited O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202062342.g16Ng1s34852>