Date: Thu, 06 Nov 2008 10:03:23 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: danfe@FreeBSD.org Cc: svn-src-head@FreeBSD.org, des@des.no, svn-src-all@FreeBSD.org, alfred@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r184610 - in head: lib/libusb20 share/man/man4 sys/conf sys/dev/sound/pcm sys/dev/usb2 sys/dev/usb2/bluetooth sys/dev/usb2/controller sys/dev/usb2/core sys/dev/usb2/ethernet sys/dev/usb... Message-ID: <20081106.100323.195417660.imp@bsdimp.com> In-Reply-To: <20081106101156.GA40311@FreeBSD.org> References: <20081105.144840.-432836001.imp@bsdimp.com> <864p2l5hf1.fsf@ds4.des.no> <20081106101156.GA40311@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
In message: <20081106101156.GA40311@FreeBSD.org>
Alexey Dokuchaev <danfe@FreeBSD.ORG> writes:
: On Thu, Nov 06, 2008 at 10:32:02AM +0100, Dag-Erling Sm??rgrav wrote:
: > "M. Warner Losh" <imp@bsdimp.com> writes:
: > > Dag-Erling_Sm??rgrav <des@des.no> writes:
: > > > It looks like whoever wrote this went out of their way to find new and
: > > > creative ways to break just about every style rule we have.
: > > Not just coding style, but also style of /dev entries, the modules
: > > style, etc.
: >
: > So the question is, why was this code imported at all?
:
: Seconded, especially since it says the code was reviewed by you Warner in
: the commit log.
Unfortunately, most of my reviews were ignored, as were those of a
great many other people. There's lots of pressure for this code from
the user community. It is an experiment, one that may well ultimately
fail.
Warner
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081106.100323.195417660.imp>