Date: Wed, 26 Aug 2020 07:39:55 +0200 From: Michal Meloun <meloun.michal@gmail.com> To: freebsd-arm@freebsd.org Subject: Re: Kmod driver at iicbus. attach() and config_intrhook(9) Message-ID: <b9162ae3-6f4c-d919-6491-0d87a7cb3abc@gmail.com> In-Reply-To: <20200825203313.GJ4213@funkthat.com> References: <7fabb65d99aaa74775c1daa91bffb873@mh.net.ru> <3249fa7e-554a-83ef-57b2-7c38aa0b4591@FreeBSD.org> <20200819072409.GA59949@bluezbox.com> <05145b71692af74b103bb226a2e93a15e1e851cb.camel@freebsd.org> <d603cf3b852d5e18fa5faa9066f643a3@mh.net.ru> <20200820223918.GC4213@funkthat.com> <d709ba1d3473f5d4353dc1109c198f8acb8ffa28.camel@freebsd.org> <496ed13afb2327d6416664b4dacfc346@mh.net.ru> <20200824204708.GH4213@funkthat.com> <6be8abd0-185c-dbbb-5964-1e2ad92ad213@FreeBSD.org> <20200825203313.GJ4213@funkthat.com>
index | next in thread | previous in thread | raw e-mail
On 25.08.2020 22:33, John-Mark Gurney wrote: > Andriy Gapon wrote this message on Tue, Aug 25, 2020 at 10:21 +0300: >> On 24/08/2020 23:47, John-Mark Gurney wrote: >>> What driver is used for i2c on the Orange? I've tried to firgure it >>> out from dts + source, but it isn't clear. >> >> a10_twsi > > Thanks. And this explains why I couldn't find it in arm/allwinner.. :) > > Yeah, this is using bus_generic_attach... > > But it looks like it supports interruptless operation. Is there a flag > for when interrupts are enabled? > > Because the check in sys/dev/iicbus/twsi/twsi.c:twsi_transfer could be > changed from: > if (sc->have_intr == false) > > to: > if (sc->have_intr == false || interrupts_not_enabled) > > And that could fix things. See one of existing drivers for inspiration. For example: https://svnweb.freebsd.org/base/head/sys/arm64/rockchip/rk_i2c.c?revision=358278&view=markup&pathrev=364777#l528 Michalhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b9162ae3-6f4c-d919-6491-0d87a7cb3abc>