Date: Tue, 18 Aug 2020 10:14:14 -0400 From: Mark Johnston <markj@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364310 - in head/sys: kern vm Message-ID: <20200818141414.GC28906@raichu> In-Reply-To: <8f9d96f9-ecbb-1ed9-5347-b4b25662a6a2@FreeBSD.org> References: <202008171537.07HFb8a6058296@repo.freebsd.org> <8f9d96f9-ecbb-1ed9-5347-b4b25662a6a2@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 18, 2020 at 01:03:25AM +0300, Andriy Gapon wrote: > On 17/08/2020 18:37, Gleb Smirnoff wrote: > > Author: glebius > > Date: Mon Aug 17 15:37:08 2020 > > New Revision: 364310 > > URL: https://svnweb.freebsd.org/changeset/base/364310 > > > > Log: > > With INVARIANTS panic immediately if M_WAITOK is requested in a > > non-sleepable context. Previously only _sleep() would panic. > > This will catch misuse of M_WAITOK at development stage rather > > than at stress load stage. > > > > Reviewed by: markj > > Differential Revision: https://reviews.freebsd.org/D26027 > > I think that there is going to be a lot of fallout from this. > Will you handle it? > A warning from WITNESS is one thing, a panic is another. Indeed, based on a few reports from freebsd-current I reverted the commit. It seems there are a number of places in CAM that will require modification, particularly in async event handling. Note that CAM doneq threads execute handlers with TD_NO_SLEEPING.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200818141414.GC28906>