Date: Thu, 1 Jul 2010 04:35:23 +0530 From: "Jayachandran C." <c.jayachandran@gmail.com> To: Juli Mallett <jmallett@freebsd.org> Cc: freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD Message-ID: <AANLkTim04OgOAtVOlbY87wyJJqzZRGh2V9uRg5e-V-Sj@mail.gmail.com> In-Reply-To: <AANLkTinIQjzaldNkzZV97tvd2vJMAjBEsu1f8SO4roay@mail.gmail.com> References: <AANLkTik8jFkB7FTIIhyjalkfv1c0yXqse57Jzz527uf_@mail.gmail.com> <897604F6-95C4-49A8-B11F-277A74C8DBAE@gmail.com> <AANLkTilfW_zOFKuIa0gJ3ahTo-vGC1VNk99a1H24uFRq@mail.gmail.com> <AANLkTil78NFxH016C7MntD8L3d4rFlCudJ0Lv22L0KCb@mail.gmail.com> <3C0AEF9B-AE0C-4459-A4E1-2C8C30C10FD6@gmail.com> <AANLkTint7Hyf79EH29OLsIfreQRd7dQMdvX9wRq4v_yG@mail.gmail.com> <C6D73C96-3640-4502-A9D7-B3597E37E80A@gmail.com> <AANLkTilQIqF4FCfgLdVcKdcsAUVjCmr89Lu0TEXUFdYN@mail.gmail.com> <25B9A19D-0A6B-4731-8FB1-A2C6722F0E9C@gmail.com> <AANLkTim_9-G6ZuA0vkpLeG4n4GVBpBlxhGBy_7eQoIM4@mail.gmail.com> <C1BD2512-8A48-4AB2-B9CA-C46DDCBE5256@gmail.com> <AANLkTimgyYggdDYchEfb3yskmA0PsttjVzkOSMaWFsjH@mail.gmail.com> <AANLkTinIQjzaldNkzZV97tvd2vJMAjBEsu1f8SO4roay@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 1, 2010 at 4:17 AM, Juli Mallett <jmallett@freebsd.org> wrote: > On Wed, Jun 30, 2010 at 15:40, Jayachandran C. <c.jayachandran@gmail.com>= wrote: >> I've attached the final(final.diff) version I want to check-in, can >> you please quickly test it? >> >> If that does not work, can you tell me if the attached alt1.diff or >> alt2.diff works? The try.diff had three changes: handle case of >> index>0, remove pagemask operation, restore full entryhi instead of >> asid. So if the first does not work, this will help narrow down the >> rest of the cases. >> >> Hopefully this is the last iteration :) > > Hi JC, > > I think you're right that the issue is not masking enough bits in > EntryHi. =A0I suspect the other changes are not necessary and I feel > that the change to always add the entry if it doesn't exist is > undesirable if it's unnecessary. =A0When a lot of otherwise-unused > mappings are changing, this has the effect of spilling the TLB which > kills performance. =A0I hope someone is willing to try just the > TLBHI_ENTRY changes to make sure that fixes it. I had a patch that did just the EntryHi thing (the ealier mail pte.h-fix.diff), and that did not fix the issue, that is why I just ended up doing what the original code did. Also, I don't think the pagemask read/write is necessary, it should not have any effect, as far i can see. JC.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTim04OgOAtVOlbY87wyJJqzZRGh2V9uRg5e-V-Sj>