Date: Fri, 12 Apr 2019 18:16:32 -0700 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Tycho Nightingale <tychon@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r346150 - head/sys/vm Message-ID: <A26EB6AF-88A8-4D34-A331-0318FF42C3A8@gmail.com> In-Reply-To: <4DA68C34-12A0-4E62-B868-F7BE10CB06BD@freebsd.org> References: <201904121246.x3CCkP2m027680@repo.freebsd.org> <94A39E35-A8E0-42A4-8467-096D4AAD0F89@gmail.com> <4DA68C34-12A0-4E62-B868-F7BE10CB06BD@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 12, 2019, at 13:10, Tycho Nightingale <tychon@freebsd.org> wrote: > >> On Apr 12, 2019, at 12:43 PM, Enji Cooper <yaneurabeya@gmail.com> wrote: >> >> >>> On Apr 12, 2019, at 5:46 AM, Tycho Nightingale <tychon@FreeBSD.org> wrote: >>> >>> Author: tychon >>> Date: Fri Apr 12 12:46:25 2019 >>> New Revision: 346150 >>> URL: https://svnweb.freebsd.org/changeset/base/346150 >>> >>> Log: >>> for a cache-only zone the destructor tries to destroy a non-existent keg >>> >>> Reviewed by: markj >>> Sponsored by: Dell EMC Isilon >>> Differential Revision: https://reviews.freebsd.org/D19835 >> >> >> Hi Tycho! >> Is the goal of this change to prevent a panic (with an INVARIANTS kernel)? >> Thank you! >> -Enji > > Hi, > > The goal of this change is to fix a regression introduced in r343026. It does cause a panic independent of INVARIANTS. Fortunately there isn’t currently any in-tree code which triggers the panic. It does however show up when running with the patch under review in D19845. Hi again! Thank you for the explanation! This part was missing from the commit message, hence my question. I wanted to make sure I understood the change in this commit properly. Cheers! -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A26EB6AF-88A8-4D34-A331-0318FF42C3A8>