Date: Tue, 19 Apr 2005 15:20:43 -0400 (EDT) From: Daniel Eischen <deischen@freebsd.org> To: Hajimu UMEMOTO <ume@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/net getproto.c getprotoent.c getprotoname.c netdb_private.h Message-ID: <Pine.GSO.4.43.0504191516330.6115-100000@sea.ntplx.net> In-Reply-To: <ygeu0m2zim9.wl%ume@mahoroba.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 20 Apr 2005, Hajimu UMEMOTO wrote: > Hi, > > deischen> Stop polluting the namespace. If the externally visible functions > deischen> you add are not in a standard and are only for use within libc, > deischen> they need to be prefixed with "_" or "__". I haven't paid attention > deischen> to your other commits in libc, but please go back and fix other > deischen> occurrences if there are any. Or make them static if they can > deischen> be. > > The functions I added are prefixed with `__'. Look at src/lib/libc/net/getprotoent.c (the only file I examined). You added getprotoent_r, setprotoent_r, and endprotoent_r. Even your commit message says this ;-) These functions are not in the POSIX spec as far as I can see. -- Dan Eischen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.43.0504191516330.6115-100000>