Date: Tue, 3 Jul 2018 17:38:11 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net>, Warner Losh <imp@bsdimp.com> Cc: Eitan Adler <lists@eitanadler.com>, "freebsd-arch@freebsd.org" <arch@freebsd.org> Subject: Re: xstr, mkstr Message-ID: <31b491de-ac5e-ca0f-5f84-96cfa7c02699@FreeBSD.org> In-Reply-To: <201807031756.w63HuM2c039271@pdx.rh.CN85.dnsmgr.net> References: <201807031756.w63HuM2c039271@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--HLfNzFQaF5XpRKdowEr4KhqURDVvYUv1n
Content-Type: multipart/mixed; boundary="UbNnOy9TivdUOWyAzHZgc0JsZL2zcCfL4";
protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net>,
Warner Losh <imp@bsdimp.com>
Cc: Eitan Adler <lists@eitanadler.com>,
"freebsd-arch@freebsd.org" <arch@freebsd.org>
Message-ID: <31b491de-ac5e-ca0f-5f84-96cfa7c02699@FreeBSD.org>
Subject: Re: xstr, mkstr
References: <201807031756.w63HuM2c039271@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201807031756.w63HuM2c039271@pdx.rh.CN85.dnsmgr.net>
--UbNnOy9TivdUOWyAzHZgc0JsZL2zcCfL4
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 7/3/2018 10:56 AM, Rodney W. Grimes wrote:
> [ Charset UTF-8 unsupported, converting... ]
>> On Tue, Jul 3, 2018, 11:41 AM Rodney W. Grimes <
>> freebsd-rwg@pdx.rh.cn85.dnsmgr.net> wrote:
>>
>>> [ Charset UTF-8 unsupported, converting... ]
>>>> On 7/3/18 8:26 AM, Warner Losh wrote:
>>>>>> "As far as I can tell" needs to be a bit stronger,
>>>>>>
>>>>>> Agreed. But before doing work we should first make sure that the w=
ork
>>>>>> will be productive.
>>>>>>
>>>>>
>>>>> Xstr and most are best thought of as a final pass of the old pcc
>>> compiler.
>>>>> This functionality moved into gcc before the egcs split back in the=
>>> 90s.
>>>>> The compiler has done this work for two decades now. Nobody uses it=
, or
>>>>> needs it today.
>>>>>
>>>>> Unlike tip or cu, nobody at all uses these.
>>>>
>>>> Agreed, these tools are quite obscure and I don't think _FreeBSD_ ha=
s
>>> ever
>>>> used them.
>>>
>>> I thought someone already pointed out places in the src tree
>>> that had references to them, though they may
>>>
>>
>> You removed the SHAREDSTRINGS support in r3493 back in 1994. It's been=
>> unused since then. There are comments that suggest it never worked in
>> FreeBSD, but that may be 2.0 and newer only.
>=20
> Removed it, not commented it out. Someone else on this thread made
> statement that stuff is refering to these tools, that could not been
> what I removed in r3493.
>=20
> I do see that some of what I removed in r3493 is now back as bmake
> has moved to contrib/ and these strings are now there:
> ./contrib/bmake/mk/prog.mk:.if defined(SHAREDSTRINGS)
> ./contrib/bmake/mk/README:SHAREDSTRINGS If defined, a new .c.o rule is =
used that results in shared
>=20
These files (contrib/bmake/mk/*) are not used anywhere for FreeBSD. It's
just part of the bmake distribution.
On the otherhand I don't see the point in removing something that isn't
harming anything, is not worth talking about in terms of size or build
time, and is unlikely to need maintenance.
This argument of "not useful" is a bit subjective. Is cut useful when we
have awk? I won't go on.
> Those are parts that I totally removed from
> share/mk/{bsd.README,bsd.prog.mk} in r3493.
>=20
> The only note I see about "never worked" is that prog.mk stuff
> is suppose to have issues with Parallel make, thats in the
> contrib/bmake/mk/README. Where do you have a reference to
> never worked in FreeBSD?
>=20
--=20
Regards,
Bryan Drewery
--UbNnOy9TivdUOWyAzHZgc0JsZL2zcCfL4--
--HLfNzFQaF5XpRKdowEr4KhqURDVvYUv1n
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJbPBbzAAoJEDXXcbtuRpfPp/UIALond9f1zDPAQvoa61EHD0iF
+YyPeqZMljqug6CW1odwgneu+lTtV5MKMGNVzlyKhpcSBl8fRkc100eHkrxePxFy
+ZeJNVtC5sMU0TiPOHxkydEo4MLSj3CNk9XE+1LsHmWqEhQuP1nf3uKlXLaKLEef
1NCJ7TIG0fh3kiEFLvh9Q8kUIji61XxUZ22HuEQ2xCBf6Kw65FUXp5COKf21ZT61
TpENb18zovd/tQuZ6aWmIkLyK5F9ceLFMqTqkNBbAS/osNf9gpcerU6+fzAvvpnr
mg8uEMdxXIYt2Jd7SLxAR0H89xsfX2WOliZxW18YU775ysxxsjzduJPdh9aRKpk=
=Xtu8
-----END PGP SIGNATURE-----
--HLfNzFQaF5XpRKdowEr4KhqURDVvYUv1n--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31b491de-ac5e-ca0f-5f84-96cfa7c02699>