Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Sep 2015 01:05:59 +0300
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Hans Petter Selasky <hselasky@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys
Message-ID:  <20150916220559.GS1023@FreeBSD.org>
In-Reply-To: <201509141052.t8EAqRWf008293@repo.freebsd.org>
References:  <201509141052.t8EAqRWf008293@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
  Hans,

On Mon, Sep 14, 2015 at 10:52:27AM +0000, Hans Petter Selasky wrote:
H> Author: hselasky
H> Date: Mon Sep 14 10:52:26 2015
H> New Revision: 287780
H> URL: https://svnweb.freebsd.org/changeset/base/287780
H> 
H> Log:
H>   Implement callout_drain_async(), inspired by the projects/hps_head
H>   branch.
H>   
H>   This function is used to drain a callout via a callback instead of
H>   blocking the caller until the drain is complete. Refer to the
H>   callout_drain_async() manual page for a detailed description.
H>   
H>   Limitation: If a lock is used with the callout, the callout can only
H>   be drained asynchronously one time unless the callout_init_mtx()
H>   function is called again. This limitation is not present in
H>   projects/hps_head and will require more invasive changes to the
H>   timeout code, which was not in the scope of this patch.
H>   
H>   Differential Revision:	https://reviews.freebsd.org/D3521
H>   Reviewed by:		wblock
H>   MFC after:		1 month

Weren't you explicitly asked not to touch this system without a proper
review and discussion?

Presense of code in your own branch doesn't justify the change. Neither
does differential revision, that was reviewed only by a documentation
committer.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150916220559.GS1023>