Date: Sat, 1 Nov 2025 20:49:28 +0100 (CET) From: Ronald Klop <ronald-lists@klop.ws> To: Dries Michiels <driesm@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, dev-commits-ports-all@FreeBSD.org Subject: Re: git: d7e3dafa66cf - main - net/dhcpcd: fails to get address and fails to exit Message-ID: <2054904190.16591.1762026568818@localhost> In-Reply-To: <202511010941.5A19fOrg011314@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Does the port need a portrevision bump? As it is not a compile error but runtime, I think enforcing a rebuild is appropriate. Plus, the user will know if he/she has the fix installed or not. Regards, Ronald Van: Dries Michiels <driesm@FreeBSD.org> Datum: 1 november 2025 10:41 Aan: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Onderwerp: git: d7e3dafa66cf - main - net/dhcpcd: fails to get address and fails to exit > > > The branch main has been updated by driesm: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=d7e3dafa66cf79c7299da2428b43242559799838 > > commit d7e3dafa66cf79c7299da2428b43242559799838 > Author: Gleb Smirnoff > AuthorDate: 2025-11-01 09:37:42 +0000 > Commit: Dries Michiels > CommitDate: 2025-11-01 09:41:18 +0000 > > net/dhcpcd: fails to get address and fails to exit > > PR: 289842 > --- > net/dhcpcd/files/patch-src_privsep.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/net/dhcpcd/files/patch-src_privsep.c b/net/dhcpcd/files/patch-src_privsep.c > new file mode 100644 > index 000000000000..b9d22affe381 > --- /dev/null > +++ b/net/dhcpcd/files/patch-src_privsep.c > @@ -0,0 +1,24 @@ > +--- src/privsep.c.orig 2025-06-01 18:40:28 UTC > ++++ src/privsep.c > +@@ -934,7 +934,9 @@ ps_sendpsmmsg(struct dhcpcd_ctx *ctx, int fd, > + } else > + iovlen = 1; > + > +- len = writev(fd, iov, iovlen); > ++ len = sendmsg(fd, > ++ &(struct msghdr){ .msg_iov = iov, .msg_iovlen = iovlen }, MSG_EOR); > ++ > + if (len == -1) { > + if (ctx->options & DHCPCD_FORKED && > + !(ctx->options & DHCPCD_PRIVSEPROOT)) > +@@ -1063,7 +1065,9 @@ ps_sendcmdmsg(int fd, uint16_t cmd, const struct msghd > + psm.ps_namelen + psm.ps_controllen + psm.ps_datalen + cmsg_padlen; > + if (psm.ps_datalen != 0) > + memcpy(p, msg->msg_iov[0].iov_base, psm.ps_datalen); > +- return writev(fd, iov, __arraycount(iov)); > ++ return sendmsg(fd, > ++ &(struct msghdr){ .msg_iov = iov, .msg_iovlen = __arraycount(iov) }, > ++ MSG_EOR); > + > + nobufs: > + errno = ENOBUFS; > > > > [-- Attachment #2 --] <html><head></head><body>Does the port need a portrevision bump? As it is not a compile error but runtime, I think enforcing a rebuild is appropriate. Plus, the user will know if he/she has the fix installed or not.<div><br></div><div>Regards,</div><div>Ronald</div><div><br><p><small><strong>Van:</strong> Dries Michiels <driesm@FreeBSD.org><br><strong>Datum:</strong> 1 november 2025 10:41<br><strong>Aan:</strong> ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org<br><strong>Onderwerp:</strong> git: d7e3dafa66cf - main - net/dhcpcd: fails to get address and fails to exit<br></small></p><blockquote style="margin-left: 5px; border-left: 3px solid #ccc; margin-right: 0px; padding-left: 5px;"><div class="MessageRFC822Viewer do_not_remove" id="P"><!-- P --> <!-- processMimeMessage --><div class="TextPlainViewer do_not_remove" id="P.P"><!-- P.P -->The branch main has been updated by driesm:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=d7e3dafa66cf79c7299da2428b43242559799838">https://cgit.FreeBSD.org/ports/commit/?id=d7e3dafa66cf79c7299da2428b43242559799838</a><br>; <br> commit d7e3dafa66cf79c7299da2428b43242559799838<br> Author: Gleb Smirnoff <glebius@freebsd.org><br> AuthorDate: 2025-11-01 09:37:42 +0000<br> Commit: Dries Michiels <driesm@freebsd.org><br> CommitDate: 2025-11-01 09:41:18 +0000<br> <br> net/dhcpcd: fails to get address and fails to exit<br> <br> PR: 289842<br> ---<br> net/dhcpcd/files/patch-src_privsep.c | 24 ++++++++++++++++++++++++<br> 1 file changed, 24 insertions(+)<br> <br> diff --git a/net/dhcpcd/files/patch-src_privsep.c b/net/dhcpcd/files/patch-src_privsep.c<br> new file mode 100644<br> index 000000000000..b9d22affe381<br> --- /dev/null<br> +++ b/net/dhcpcd/files/patch-src_privsep.c<br> @@ -0,0 +1,24 @@<br> +--- src/privsep.c.orig 2025-06-01 18:40:28 UTC<br> ++++ src/privsep.c<br> +@@ -934,7 +934,9 @@ ps_sendpsmmsg(struct dhcpcd_ctx *ctx, int fd,<br> + } else<br> + iovlen = 1;<br> + <br> +- len = writev(fd, iov, iovlen);<br> ++ len = sendmsg(fd,<br> ++ &(struct msghdr){ .msg_iov = iov, .msg_iovlen = iovlen }, MSG_EOR);<br> ++<br> + if (len == -1) {<br> + if (ctx->options & DHCPCD_FORKED &&<br> + !(ctx->options & DHCPCD_PRIVSEPROOT))<br> +@@ -1063,7 +1065,9 @@ ps_sendcmdmsg(int fd, uint16_t cmd, const struct msghd<br> + psm.ps_namelen + psm.ps_controllen + psm.ps_datalen + cmsg_padlen;<br> + if (psm.ps_datalen != 0)<br> + memcpy(p, msg->msg_iov[0].iov_base, psm.ps_datalen);<br> +- return writev(fd, iov, __arraycount(iov));<br> ++ return sendmsg(fd,<br> ++ &(struct msghdr){ .msg_iov = iov, .msg_iovlen = __arraycount(iov) },<br> ++ MSG_EOR);<br> + <br> + nobufs:<br> + errno = ENOBUFS;<br> </driesm@freebsd.org></glebius@freebsd.org></div><!-- TextPlainViewer --> <hr> </div><!-- MessageRFC822Viewer --> </blockquote><br><br><br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2054904190.16591.1762026568818>