Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 Oct 2019 08:48:09 +0200
From:      Tobias Kortkamp <tobik@freebsd.org>
To:        Muhammad Moinur Rahman <bofh@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r513844 - head/emulators/qemu
Message-ID:  <20191006064809.GA99162@urd.tobik.me>
In-Reply-To: <4093EC81-7A02-4DE9-AF83-9DBF45F6A99A@FreeBSD.org>
References:  <201910052027.x95KRQoY068649@repo.freebsd.org> <20191006062141.GA45072@urd.tobik.me> <4093EC81-7A02-4DE9-AF83-9DBF45F6A99A@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--UugvWAfsgieZRqgk
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Oct 06, 2019 at 12:25:21PM +0600, Muhammad Moinur Rahman wrote:
> qemu has a slave port. So we are using USES?. But for qemu-utils or qemu-=
guest-agent we just need USES=3Dxorg and nothing else. Adding USES=3Dxorg d=
oesn=E2=80=99t work.  :(

It seems I have been unclear.  USES?+=3D (note the extra +) does not
do what you want and is a nop.  It does not append to 'USES' but
it appends to 'USES?' which is not right at all.

$ make -C emulators/qemu -V 'USES?'
xorg

> > On 6 Oct, 2019, at 12:21, Tobias Kortkamp <tobik@freebsd.org> wrote:
> >=20
> > On Sat, Oct 05, 2019 at 08:27:26PM +0000, Muhammad Moinur Rahman wrote:
> >> Author: bofh
> >> Date: Sat Oct  5 20:27:25 2019
> >> New Revision: 513844
> >> URL: https://svnweb.freebsd.org/changeset/ports/513844
> >>=20
> >> Log:
> >>  emulators/qemu: Update version 3.1.1=3D>3.1.1.1
> >>=20
> >> Modified:
> >>  head/emulators/qemu/Makefile
> >>  head/emulators/qemu/distinfo
> >>=20
> >> Modified: head/emulators/qemu/Makefile
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> >> --- head/emulators/qemu/Makefile	Sat Oct  5 18:52:36 2019	(r513843)
> >> +++ head/emulators/qemu/Makefile	Sat Oct  5 20:27:25 2019	(r513844)
> >> @@ -2,7 +2,7 @@
> >> # $FreeBSD$
> >>=20
> >> PORTNAME=3D	qemu
> >> -PORTVERSION=3D	3.1.1
> >> +PORTVERSION=3D	3.1.1.1
> >> CATEGORIES=3D	emulators
> >> MASTER_SITES=3D	https://download.qemu.org/
> >> DIST_SUBDIR=3D	qemu/${PORTVERSION}
> >> @@ -20,6 +20,7 @@ LIB_DEPENDS?=3D	libnettle.so:security/nettle \
> >>=20
> >> .if !defined(PKGNAMESUFFIX) || (${PKGNAMESUFFIX} !=3D "-utils" && ${PK=
GNAMESUFFIX} !=3D "-guest-agent")
> >> ONLY_FOR_ARCHS=3D	amd64 i386 powerpc powerpc64
> >> +USES?+=3D		xorg
> >=20
> > It is unfortunate that make(1) accepts this, but 'USES?+=3D' means
> > 'append to a variable called USES?' which is probably wrong.  What
> > did you mean here?  'USES?=3D', 'USES+=3D' or maybe it should be removed
> > again?  At the moment this does not really do anything.
>=20

--UugvWAfsgieZRqgk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl2ZjiZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1
N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF
H2GCvwgArpqzh653MGbt39Qe9df3CsijGriS9lyS605XiWEqYwq+D/b9Tm4LJ7Os
dOHxL9AP2S9cDIqrMCXIN8y9mFQPSxk/zx5E30nSPc8Db2PtN2xRg8pf2IZaTFYe
l88ZHm/Yt/ZOapQPgKpNweiKGYpOfi3fB8waNsW+A+dsIZQvRyYQJqygNt57yVX6
bOgwvI16BG8NFoZMamZ8GeSw9QqzsZ4d/94EWD7C1s49Pn0RO1q6B2zKYngoofzq
lpe4lD8oSfTuOGd8+z70oOzPy1/6uV2iNEKM9GqfTNLHTPMcZIk495TrW9HJoqdo
CrtdukVcYtIc9ibsVKGm6+gEgwC+pw==
=YMd8
-----END PGP SIGNATURE-----

--UugvWAfsgieZRqgk--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191006064809.GA99162>