Date: Sun, 24 Mar 2024 12:10:18 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Michael Gmelin <grembo@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: d79ba67c4595 - main - devel/phorgeit-arcanist-lib: New port Message-ID: <0984e02f827dea473a52c5b6475aa108@mail.infomaniak.com> In-Reply-To: <202403241025.42OAPS1P083257@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
Hi, Why did this remove "- SUBDIR += php-Psr_Log" in devel/Makefile ? Please follow Porters Handbook when it comes to versioning and usage of variables. Commit refers to https://github.com/phorgeit/arcanist/commit/174bf094ef9fe26770903c912cf29b6c78760b26 which was committed, Date: Wed, 28 Feb 2024 12:29:14 +0100 Why does PORTVERSION say 20240304? Upstream uses tags so utilize those and do backports of needed unless you never intend to follow upstream, in that case you should use commit date and prefix g. See https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github Use DISTVERSION whenever possible as shown in examples. please use the same length of commits when using GH_TAGNAME as shown in Porters Handbook. Best regards, Danielhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0984e02f827dea473a52c5b6475aa108>