Date: Fri, 28 Aug 2015 16:54:58 +0930 From: "O'Connor, Daniel" <darius@dons.net.au> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: NGie Cooper <yaneurabeya@gmail.com>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Xin LI <delphij@freebsd.org> Subject: Re: svn commit: r287236 - head/bin/df Message-ID: <E8E510CD-EF49-489D-8DD2-1EFEBE0E470A@dons.net.au> In-Reply-To: <20150828060458.GA20642@FreeBSD.org> References: <201508280044.t7S0ixfW038766@repo.freebsd.org> <20150828044312.GA88538@FreeBSD.org> <CAGHfRMDw0=-ze4cd7mAoHO_n%2Bt8NdYsR0On2YE5=s_gQ4=xveg@mail.gmail.com> <20150828060458.GA20642@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 28 Aug 2015, at 15:34, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote: >> On Thu, Aug 27, 2015 at 9:43 PM, Alexey Dokuchaev <danfe@freebsd.org> = wrote: >>> On Fri, Aug 28, 2015 at 12:44:59AM +0000, Xin LI wrote: >>>> New Revision: 287236 >>>> URL: https://svnweb.freebsd.org/changeset/base/287236 >>>>=20 >>>> Log: >>>> Use exit() instead of return in main(). >>>=20 >>> Because?.. >>=20 >> Probably because of libxo... >=20 > I'm just wondering how hard is it to write sensible commit logs. :( To put it in a hopefully more helpful way.. Please write why your change is doing something, not what it is doing. Saying what it is doing is OK if it's really hairy, but 99% of the time = that isn't the case. Assuming this is a libxo thing the commit log should have been something = like.. "Use exit out of main otherwise libxo will not flush properly" (or something similar) Although it would be surprising if libxo required you to use exit().. -- Daniel O'Connor "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E8E510CD-EF49-489D-8DD2-1EFEBE0E470A>