Date: Thu, 28 May 2026 10:30:37 +0200 From: Antoine Brodin <antoine@freebsd.org> To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>, Bryan Drewery <bdrewery@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Mark Johnston <markj@freebsd.org> Subject: Re: git: bd15d6ef126e - main - libarchive: Force GNU iconv compatibility on FreeBSD Message-ID: <CAALwa8kfobaOQFKoihKACtpUrP2WkeTPaZogT2gGB0xxc-1Kcg@mail.gmail.com> In-Reply-To: <86eciwx7wg.fsf@ltc.des.dev> References: <6a16eeef.475db.2283bfa4@gitrepo.freebsd.org> <CAALwa8=2idBFeqnW1aDHgcswF4Gr6QQP9S%2BgfcHksD=jAWWaPA@mail.gmail.com> <86eciwx7wg.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
On Thu, May 28, 2026 at 10:20 AM Dag-Erling Smørgrav <des@freebsd.org> wrote: > Antoine Brodin <antoine@freebsd.org> writes: > > Dag-Erling Smørgrav <des@freebsd.org> writes: > > > commit bd15d6ef126ee4c0eac931117f6bbbf6f9a3fc72 > > > Author: Mark Johnston <markj@FreeBSD.org> > > > AuthorDate: 2026-05-20 16:39:40 +0000 > > > Commit: Dag-Erling Smørgrav <des@FreeBSD.org> > > > CommitDate: 2026-05-27 13:10:57 +0000 > > > > > > libarchive: Force GNU iconv compatibility on FreeBSD > > > > > > When libarchive is compiled with FreeBSD's native iconv instead of > > > libiconv, as happens with libarchive in the base system, we need to > > > configure iconv(3) to handle invalid sequences by returning -1, as > > > iconv_strncat_in_locale() assumes GNU iconv semantics. > > > > > > This corresponds to upstream PR 3056. > > > > > > PR: 294577 > > > MFC after: 1 week > > Could this change break some ports? > > Your logs show that LC_COLLATE is set to C. It should be set to > C.UTF-8, or simply not set at all since LANG is already C.UTF-8. I add bapt@ and bdrewery@ This LC_COLLATE comes from https://github.com/freebsd/poudriere/commit/a69f7a01ea7318aafc6d20eff500849cb98c5c7a Antoinehome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8kfobaOQFKoihKACtpUrP2WkeTPaZogT2gGB0xxc-1Kcg>
