Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 31 Oct 2019 22:16:21 +0000 (UTC)
From:      Vincenzo Maffione <vmaffione@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r354231 - head/sys/net
Message-ID:  <201910312216.x9VMGLuN090707@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: vmaffione
Date: Thu Oct 31 22:16:20 2019
New Revision: 354231
URL: https://svnweb.freebsd.org/changeset/base/354231

Log:
  netmap: fix build issue in netmap_user.h
  
  The issue was a comparison of integers of different signs
  on 32 bit architectures.
  
  Reported by:	jenkins
  MFC after:	1 week

Modified:
  head/sys/net/netmap_user.h

Modified: head/sys/net/netmap_user.h
==============================================================================
--- head/sys/net/netmap_user.h	Thu Oct 31 21:32:59 2019	(r354230)
+++ head/sys/net/netmap_user.h	Thu Oct 31 22:16:20 2019	(r354231)
@@ -1116,7 +1116,7 @@ nm_dispatch(struct nm_desc *d, int cnt, nm_cb_t cb, u_
 				slot = &ring->slot[i];
 				d->hdr.len += slot->len;
 				nbuf = (u_char *)NETMAP_BUF(ring, slot->buf_idx);
-				if (oldbuf != NULL && nbuf - oldbuf == ring->nr_buf_size &&
+				if (oldbuf != NULL && nbuf - oldbuf == (int)ring->nr_buf_size &&
 						oldlen == ring->nr_buf_size) {
 					d->hdr.caplen += slot->len;
 					oldbuf = nbuf;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201910312216.x9VMGLuN090707>