Date: Thu, 9 Aug 2012 15:10:03 GMT From: dfilter@FreeBSD.ORG (dfilter service) To: freebsd-bugs@FreeBSD.org Subject: Re: kern/95239: commit references a PR Message-ID: <201208091510.q79FA3Vt088892@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/95239; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/95239: commit references a PR Date: Thu, 9 Aug 2012 15:04:21 +0000 (UTC) Author: jilles Date: Thu Aug 9 15:04:06 2012 New Revision: 239150 URL: http://svn.freebsd.org/changeset/base/239150 Log: nftw(): Do not check the maxfds argument against OPEN_MAX. Apart from the fact that nothing should have OPEN_MAX as a limit (as opposed to RLIMIT_NOFILE from getrlimit() or _SC_OPEN_MAX from sysconf()), POSIX does not require us to check this. PR: 95239 Submitted by: Todd Miller Modified: head/lib/libc/gen/nftw.c Modified: head/lib/libc/gen/nftw.c ============================================================================== --- head/lib/libc/gen/nftw.c Thu Aug 9 14:46:52 2012 (r239149) +++ head/lib/libc/gen/nftw.c Thu Aug 9 15:04:06 2012 (r239150) @@ -34,7 +34,6 @@ __FBSDID("$FreeBSD$"); #include <errno.h> #include <fts.h> #include <ftw.h> -#include <limits.h> int nftw(const char *path, int (*fn)(const char *, const struct stat *, int, @@ -47,7 +46,7 @@ nftw(const char *path, int (*fn)(const c int error = 0, ftsflags, fnflag, postorder, sverrno; /* XXX - nfds is currently unused */ - if (nfds < 1 || nfds > OPEN_MAX) { + if (nfds < 1) { errno = EINVAL; return (-1); } _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208091510.q79FA3Vt088892>