Date: Mon, 12 Aug 2024 21:53:23 GMT From: Jessica Clarke <jrtc27@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 97c31cc80098 - main - kldxref: Clarify ambiguous comment Message-ID: <202408122153.47CLrNuW052616@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=97c31cc80098956688a36a173a42b54549350d40 commit 97c31cc80098956688a36a173a42b54549350d40 Author: Jessica Clarke <jrtc27@FreeBSD.org> AuthorDate: 2024-08-12 21:53:13 +0000 Commit: Jessica Clarke <jrtc27@FreeBSD.org> CommitDate: 2024-08-12 21:53:13 +0000 kldxref: Clarify ambiguous comment This previously read, to me at least, as if the not only applied to ending with ".ko", not to the entire rest of the sentence, and thus the implementation looked wrong. The history of D43507 however shows that the behaviour is as intended. --- usr.sbin/kldxref/kldxref.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/kldxref/kldxref.c b/usr.sbin/kldxref/kldxref.c index 122551940ac7..6bb0469a9ff5 100644 --- a/usr.sbin/kldxref/kldxref.c +++ b/usr.sbin/kldxref/kldxref.c @@ -839,8 +839,8 @@ main(int argc, char *argv[]) continue; /* * Skip files that generate errors like .debug, .symbol and .pkgsave - * by generally skipping all files not ending with ".ko" or that have - * no dots in the name (like kernel). + * by generally skipping all files which neither end with ".ko" + * nor have no dots in the name (like kernel). */ dot = strrchr(p->fts_name, '.'); if (dot != NULL && strcmp(dot, ".ko") != 0)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202408122153.47CLrNuW052616>