Date: Wed, 30 Apr 2003 11:10:03 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Harti Brandt <brandt@fokus.fraunhofer.de> Cc: nate@root.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h Message-ID: <6554.1051693803@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 30 Apr 2003 09:43:32 %2B0200." <20030430093931.V31027@beagle.fokus.fraunhofer.de>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20030430093931.V31027@beagle.fokus.fraunhofer.de>, Harti Brandt wri tes: >On Tue, 29 Apr 2003, M. Warner Losh wrote: > >MWL>In message: <Pine.BSF.4.21.0304291101001.75697-100000@root.org> > >MWL>: > 4) Return immediately if gone is true in fxp_ioctl >MWL>: > 5) Return immediately if gone is true in fxp_intr >MWL>: >MWL>: Not sure this approach is necessary. >MWL> >MWL>I am. Otherwise ioctl panics with recursive locks when the card is >MWL>detached. A simple kld_unload if_fxp would provoke these races, >MWL>including the recursive lock panic. > >You can replace the pointers to ioctl and start with pointers to dummy >functions. In fact, an if_dead(ifp) function which does just this would >be nice to have. isn't that what if_disc.c does already ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6554.1051693803>