Date: Thu, 02 Oct 2008 16:40:41 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: jhb@freebsd.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pccbb pccbb_pci.c Message-ID: <20081002.164041.-345492472.imp@bsdimp.com> In-Reply-To: <200810021305.47479.jhb@freebsd.org> References: <200810020629.m926TqZq036159@repoman.freebsd.org> <200810021305.47479.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200810021305.47479.jhb@freebsd.org>
John Baldwin <jhb@freebsd.org> writes:
: On Thursday 02 October 2008 02:29:45 am Warner Losh wrote:
: > imp 2008-10-02 06:29:45 UTC
: >
: > FreeBSD src repository
: >
: > Modified files:
: > sys/dev/pccbb pccbb_pci.c
: > Log:
: > SVN rev 183539 on 2008-10-02 06:29:45Z by imp
: >
: > Don't forget to match on a CLASS of PCIC_BRIDGE as well as subclass
: > PCIS_BRIDGE_CARDBUS. Otherwise, we may hit a few false positives....
:
: Shouldn't it use BUS_GENERIC_PROBE instead of BUS_DEFAULT_PROBE when matching
: purely on the class codes?
Yes. I'll fix it.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081002.164041.-345492472.imp>