Date: Fri, 14 Apr 2017 13:07:02 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Alan Somers <asomers@freebsd.org> Cc: Ngie Cooper <ngie@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r316938 - head/sbin/savecore Message-ID: <25EDEFF2-4993-4C95-B005-8670DF513B72@gmail.com> In-Reply-To: <7DCBB59B-388F-463D-8FFF-06390E5B5165@gmail.com> References: <201704141941.v3EJfmCW003347@repo.freebsd.org> <CAOtMX2gPHWRGiE9UA5AevZz=cTv_qksAWX0H-xRjDEHp0huCVg@mail.gmail.com> <499FA6FF-E691-4941-B96C-3806072D14AA@gmail.com> <CAOtMX2g49C1EqLKOsj6en3B4oaVNQyD3joohFO3QcJTUv1v93Q@mail.gmail.com> <7DCBB59B-388F-463D-8FFF-06390E5B5165@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_A38279AE-4145-470F-902C-5F719E69AB0A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 14, 2017, at 13:04, Ngie Cooper (yaneurabeya) = <yaneurabeya@gmail.com> wrote: >=20 >=20 >> On Apr 14, 2017, at 13:02, Alan Somers <asomers@freebsd.org> wrote: >=20 > ... >=20 >> Right: check_size() needs to know the on-disk size of the core dump. >> But it doesn't have any way to know the on-disk size until after it's >> written everything to disk. That's why I simply disabled the check = at >> $WORK. Another possibility would be for savecore to ignore the >> up-front check, but handle ENOSPC by deleting the fragmentary vmcore >> file. I never tried to implement that. >=20 > Let me dig through the gzip format a bit. There should be a reasonably = good upper bound approximation that we can use for compressed mini = dumps. Also: deleting truncated dumps sounds great to me: their value when = truncated is pretty low from what I remember. -Ngie --Apple-Mail=_A38279AE-4145-470F-902C-5F719E69AB0A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8SvmAAoJEPWDqSZpMIYVMwUP/is9SwaUluIZqVpzW7koduPG DNu4ejTX6ZgR0YZ8//+PiTNI4S7WfKUiCZdeIaScDDQWtftLRWUzKyhvSnyfPwLg /WPc5+NDjpih7rwmMvXm+uBRV6VhQosY83cl81DSBD7q3bhC8g00WLDH8325xaFe OPUWG2XCzyo2jzTXeABHxiX1Px/+L/+17UzorBxhnXrNAxlzBkjKwrWucmu2oef5 YgfPM/M3CkqCNPsbnVCiTQ2VQR3EsOGd6IAfJ7sQkcWiRE5o9hmpIpT62s05sftr rGjOiEXlgfMmRpxRE2r7StJ5ltPorwMI61Svc8cNTLbsOxJPwd5D4l8qvpSwVvWf HicHbLVkXegMt3yOfkD7d6aQ+PzUW68kz4zHnr8JaaTxhqEUc8fRpfeiMtyZTl2T twoD7nShU0r4whbvRfTO5nozzhVHlHwSuuvsNbEeLOyEx0hi2sv2IuN6HoV2WdHP wmSDua3qlFZYPfiFj64mXDvr8ncKkjBNQ4ycuQQVObqQrc8IfV7/P0NSwDVLaxzm 0nd+qDE+Tna18ThBwZXFOHrR0Cl91TYPL4GkHF5pdrL3VJeVWL9Xgcae79DqRWK5 YXsTk0v4dswr4gLCs3buI2Hl+wfqCGJHT5UH8fAOK2OCuHwx/ZhWvhH6K9eFjL5J 9PsHnv/15xiDkLzUhrtV =9WWL -----END PGP SIGNATURE----- --Apple-Mail=_A38279AE-4145-470F-902C-5F719E69AB0A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25EDEFF2-4993-4C95-B005-8670DF513B72>