Date: Wed, 24 Dec 2025 23:36:48 +0900 From: Hiroki Tagato <tagattie@FreeBSD.org> To: Gleb Popov <arrowd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 2cd8835b6b6d - main - x11/libxkbcommon: Fix build with non-default options setting Message-ID: <80f2d03c-46db-43a5-8870-9a6f98f07ab4@FreeBSD.org> In-Reply-To: <CALH631nHq6Cm6HWPOoORRHYYN3oBcogaVvsOd5O2cT2N%2BugO8g@mail.gmail.com> References: <694b9fb7.3c903.3034fce@gitrepo.freebsd.org> <CALH631nHq6Cm6HWPOoORRHYYN3oBcogaVvsOd5O2cT2N%2BugO8g@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
Hi Gleb,
>> +.include <bsd.port.options.mk>
>> +
>> +.if ${PORT_OPTIONS:MEVDEV} || ${PORT_OPTIONS:MWAYLAND} || ${PORT_OPTIONS:MX11}
>> +PLIST_FILES+= libexec/xkbcommon/xkbcli-interactive
>> +.endif
>> +
>> +.if ${PORT_OPTIONS:MWAYLAND} || ${PORT_OPTIONS:MX11}
>> +PLIST_FILES+= libexec/xkbcommon/xkbcli-dump-keymap
>> +.endif
>> +
>
> Just a comment that I'd rather prefer this as a PLIST_SUB, because
> "make makeplist" will re-generate these entries next time it run.
Thanks for the suggestion. That makes much sense.
I'm going to prepare an update to v1.13.1. I will incorporate your
suggestion when I make a patch.
Cheers,
Hiroki
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?80f2d03c-46db-43a5-8870-9a6f98f07ab4>