Date: Fri, 9 Nov 2012 18:06:49 +0000 From: Attilio Rao <attilio@freebsd.org> To: Ben Kaduk <minimarmot@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org> Subject: Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/openso... Message-ID: <CAJ-FndCHAjcRaVo05cHUZ=emsjgkFcuyC4pKeJxasKpTcXcu1A@mail.gmail.com> In-Reply-To: <CAK2BMK5c==SJ%2BySe7S70ZJyph_2X%2BdU%2B9zBftdatWqTVsH5rsA@mail.gmail.com> References: <201210221750.q9MHot26061585@svn.freebsd.org> <CAK2BMK5c==SJ%2BySe7S70ZJyph_2X%2BdU%2B9zBftdatWqTVsH5rsA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 6, 2012 at 10:50 PM, Ben Kaduk <minimarmot@gmail.com> wrote: > On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov <kib@freebsd.org> wrote: >> Author: kib >> Date: Mon Oct 22 17:50:54 2012 >> New Revision: 241896 >> URL: http://svn.freebsd.org/changeset/base/241896 >> >> Log: >> Remove the support for using non-mpsafe filesystem modules. >> >> In particular, do not lock Giant conditionally when calling into the >> filesystem module, remove the VFS_LOCK_GIANT() and related >> macros. Stop handling buffers belonging to non-mpsafe filesystems. >> >> The VFS_VERSION is bumped to indicate the interface change which does >> not result in the interface signatures changes. >> >> Conducted and reviewed by: attilio >> Tested by: pho >> > > Sorry for late reply. > > % --- head/sys/sys/namei.h 2011/12/29 12:28:05 228952 > % +++ head/sys/sys/namei.h 2012/10/22 17:50:54 241896 > % @@ -144,15 +144,11 @@ > % #define ISOPEN 0x00200000 /* caller is opening; return a real vnode. */ > % #define NOCROSSMOUNT 0x00400000 /* do not cross mount points */ > % #define NOMACCHECK 0x00800000 /* do not perform MAC checks */ > % -#define MPSAFE 0x01000000 /* namei() must acquire Giant if needed. */ > > It seems that removing the definition of MPSAFE causes out-of-tree > filesystem modules to not build. > Perhaps a definition can remain for some period to allow a smoother transition? > Conditional on __FreeBSD_Version is the proper fix, of course, but > takes longer to get everywhere. Hi Ben, FYI I've now removed also MNTK_MPSAFE flag. I know this could introduce some more "turbolence" for porting thirdy part stuff, but actually this only gives one single breakage window and now people can fix correctly their port/thirdy part just once. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndCHAjcRaVo05cHUZ=emsjgkFcuyC4pKeJxasKpTcXcu1A>