Date: Fri, 25 Jan 2019 07:47:52 -0600 From: Kyle Evans <self@kyle-evans.net> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Ram Kishore Vegesna <ram.vegesna@broadcom.com>, Ram Kishore Vegesna <ram@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343349 - head/sys/dev/ocs_fc Message-ID: <CACNAnaH9U4A8VwAW8MjyxvfKJQ7NSqkgF4o9Jj=WF7YWpt6Onw@mail.gmail.com> In-Reply-To: <201901251344.x0PDiGZP088635@pdx.rh.CN85.dnsmgr.net> References: <CAF7aS0qKNj7c0Y1-ywUfcqM3qXaVtpjL8-3RpGGvpXY3%2BFi_VA@mail.gmail.com> <201901251344.x0PDiGZP088635@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 25, 2019 at 7:44 AM Rodney W. Grimes <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > Hi Rodney, > > > > I fixed many coverity tool warnings as part of this commit. Adding all the > > warnings and fix details seemed over kill. > > It seems like overkill when your commiting, but if you have > have to go digging through commit history trying to find > something it helps a great deal to have good information > present there. > > You do not need to include the output from coverty, > but some amount of detail is very helpful. > We do have a tendency to note CIDs in commit messages and that's pretty helpful -- I don't know that omitting them will generally ruffle any feathers, though.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaH9U4A8VwAW8MjyxvfKJQ7NSqkgF4o9Jj=WF7YWpt6Onw>