Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 Jan 2022 10:25:41 GMT
From:      Marcin Wojtas <mw@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: afd4a4940790 - stable/13 - Disable PIE for MIPS ubldr
Message-ID:  <202201231025.20NAPfRO088331@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by mw:

URL: https://cgit.FreeBSD.org/src/commit/?id=afd4a4940790c89c27cc4fac31814a4402f31444

commit afd4a4940790c89c27cc4fac31814a4402f31444
Author:     Marcin Wojtas <mw@FreeBSD.org>
AuthorDate: 2021-02-12 15:41:49 +0000
Commit:     Marcin Wojtas <mw@FreeBSD.org>
CommitDate: 2022-01-23 10:09:53 +0000

    Disable PIE for MIPS ubldr
    
    When performing buildworld for MIPS with PIE enabled, the build fails
    with "position-independent code requires '-mabicalls'" message.
    -mno-abicalls and -fno-pic flags are explicitly set in MIPS ubldr
    makefile, so to work around this problem, set MK_PIE=no for MIPS
    ubldr.
    
    Submitted by: Dawid Gorecki <dgr@semihalf.com>
    Reviewed by: emaste
    Obtained from: Semihalf
    Sponsored by: Stormshield
    Differential Revision: https://reviews.freebsd.org/D28370
    
    (cherry picked from commit cd992885bcdfb3c2c6b761f5c3bf1c86949acdc3)
---
 stand/mips/uboot/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/stand/mips/uboot/Makefile b/stand/mips/uboot/Makefile
index 1162b7fed3b0..984582027de5 100644
--- a/stand/mips/uboot/Makefile
+++ b/stand/mips/uboot/Makefile
@@ -44,6 +44,10 @@ LDADD=		${LDR_INTERP} ${LIBUBOOT} ${LIBFDT} ${LIBUBOOT_FDT} ${LIBSA}
 
 OBJS+=  ${SRCS:N*.h:R:S/$/.o/g}
 
+# ubldr on MIPS is built with '-mno-abicalls' flag,
+# which is incompatible with PIE
+MK_PIE=		no
+
 ldscript.abs:
 	echo "UBLDR_LOADADDR = ${UBLDR_LOADADDR};" >${.TARGET}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202201231025.20NAPfRO088331>