Date: Thu, 9 Aug 2012 15:20:04 GMT From: dfilter@FreeBSD.ORG (dfilter service) To: freebsd-bugs@FreeBSD.org Subject: Re: kern/95239: commit references a PR Message-ID: <201208091520.q79FK4QY090892@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/95239; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/95239: commit references a PR Date: Thu, 9 Aug 2012 15:11:51 +0000 (UTC) Author: jilles Date: Thu Aug 9 15:11:38 2012 New Revision: 239151 URL: http://svn.freebsd.org/changeset/base/239151 Log: ftw(): Do not check the maxfds argument against OPEN_MAX. Apart from the fact that nothing should have OPEN_MAX as a limit (as opposed to RLIMIT_NOFILE from getrlimit() or _SC_OPEN_MAX from sysconf()), POSIX does not require us to check this. POSIX does have a requirement on the application that maxfds not exceed {OPEN_MAX}, but does not require the implementation to check it ("may fail"). PR: 95239 Modified: head/lib/libc/gen/ftw.c Modified: head/lib/libc/gen/ftw.c ============================================================================== --- head/lib/libc/gen/ftw.c Thu Aug 9 15:04:06 2012 (r239150) +++ head/lib/libc/gen/ftw.c Thu Aug 9 15:11:38 2012 (r239151) @@ -28,7 +28,6 @@ __FBSDID("$FreeBSD$"); #include <errno.h> #include <fts.h> #include <ftw.h> -#include <limits.h> int ftw(const char *path, int (*fn)(const char *, const struct stat *, int), @@ -40,7 +39,7 @@ ftw(const char *path, int (*fn)(const ch int error = 0, fnflag, sverrno; /* XXX - nfds is currently unused */ - if (nfds < 1 || nfds > OPEN_MAX) { + if (nfds < 1) { errno = EINVAL; return (-1); } _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208091520.q79FK4QY090892>